Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #117590

Merged
merged 14 commits into from
Nov 4, 2023
Merged

Rollup of 6 pull requests #117590

merged 14 commits into from
Nov 4, 2023

Commits on Oct 18, 2023

  1. Configuration menu
    Copy the full SHA
    3fea7cc View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Update library/core/src/primitive_docs.rs

    Co-authored-by: scottmcm <[email protected]>
    joshlf and scottmcm authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c278bc1 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Configuration menu
    Copy the full SHA
    57f570b View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. triagebot no-merges: exclude different case

    "Subtree update" as well
    pitaj committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    a745f92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0550ba5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a4768fe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bcb97ea View commit details
    Browse the repository at this point in the history
  5. Draft fleshed-out deref docs

    Re-draft Deref docs
    
    Make general advice more explicit and note the difference between
    generic and specific implementations.
    
    Re-draft DerefMut docs in-line with Deref
    
    Fix Deref docs typos
    
    Fix broken links
    
    Clarify advice for specific-over-generic impls
    
    Add comment addressing Issue rust-lang#73682
    
    x fmt
    
    Copy faillibility warning to DerefMut
    jmaargh committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    7a2f83f View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#110340 - jmaargh:jmaargh/deref-docs, r=Mark…

    …-Simulacrum
    
    Deref docs: expand and remove "smart pointer" qualifier
    
    **Ready for review**
    
    ~~This is an unpolished draft to be sanity-checked~~
    
    Fixes rust-lang#91004
    
    ~~Comments on substance and content of this are welcome. This is deliberately unpolished until ready to review so please try to stay focused on the big-picture.~~
    
    ~~Once this has been sanity checked, I will similarly update `DerefMut` and polish for review.~~
    matthiaskrgr authored Nov 4, 2023
    Configuration menu
    Copy the full SHA
    58645e0 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#116894 - joshlf:patch-12, r=RalfJung

    Guarantee that `char` has the same size and alignment as `u32`
    matthiaskrgr authored Nov 4, 2023
    Configuration menu
    Copy the full SHA
    805a56f View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#117534 - RalfJung:str, r=Mark-Simulacrum

    clarify that the str invariant is a safety, not validity, invariant
    
    Updates these docs to match rust-lang/reference#792
    matthiaskrgr authored Nov 4, 2023
    Configuration menu
    Copy the full SHA
    1ee5e12 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#117562 - pitaj:triagebot_no-merges, r=Mark-…

    …Simulacrum
    
    triagebot no-merges: exclude different case
    
    "Subtree update" as well
    
    To address [this on zulip](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/can't.20suppress.20merge.20commit.20warning)
    
    cc `@bjorn3`
    
    r? `@mark-simulacrum`
    matthiaskrgr authored Nov 4, 2023
    Configuration menu
    Copy the full SHA
    b9dcbd4 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#117570 - bvanjoi:fix-117547, r=cjgillot

    fallback for `construct_generic_bound_failure`
    
    Fixes rust-lang#117547
    
    This case regressed at rust-lang#115882.
    
    In this context, `generic_param_scope` is produced by `RPITVisitor` and not included by `hir_owner`. Therefore, I've added a fallback to address this.
    matthiaskrgr authored Nov 4, 2023
    Configuration menu
    Copy the full SHA
    a47c137 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#117583 - compiler-errors:placeholderconst-l…

    …ifetime, r=cjgillot
    
    Remove `'tcx` lifetime on `PlaceholderConst`
    
    The `'tcx` lifetime is not needed for anything, so this is a continuation of rust-lang#117139.
    matthiaskrgr authored Nov 4, 2023
    Configuration menu
    Copy the full SHA
    8912a2b View commit details
    Browse the repository at this point in the history