Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline and remove create_session. #117475

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Commits on Nov 1, 2023

  1. Inline and remove create_session.

    Currently the parts of session initialization that happen within
    `rustc_interface` are split between `run_compiler` and `create_session`.
    This split isn't necessary and obscures what's happening.
    
    This commit merges the two functions. I think a single longer function
    is much clearer than splitting this code across two functions in
    different modules, especially when `create_session` has 13 parameters,
    and is misnamed (it also creates the codegen backend). The net result is
    43 fewer lines of code.
    nnethercote committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    587af91 View commit details
    Browse the repository at this point in the history