Suggest => --> >= in comparisons

[sjwang05]

Fixes #117245

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[compiler-errors]

I don't think this handles cases where the condition is chained with &&, right? What about cases where this isn't an if block at all? What about cases where we're comparing against a literal (=> 1)?

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

• ead56b7

[sjwang05]

Thanks for the feedback! Chaining with || and && worked, but the other cases you mentioned didn't. I believe I have everything covered now--I was previously struggling with not breaking match parsing. Nevermind, looks like I missed some additional edge cases. I've also added additional tests to cover for these cases.

[bors]

☔ The latest upstream changes (presumably #117769) made this pull request unmergeable. Please resolve the merge conflicts.

[estebank]

Please squash rebase on top of a recent master.

[Noratrieb]

I tried to rebase and bless the tests for you, but there seems to be something wrong still:

--- stderr -------------------------------
error: expected one of `!`, `.`, `::`, `;`, `?`, `else`, `{`, or an operator, found `=>`
  --> /home/nils/projects/rust/tests/ui/parser/eq-gt-to-gt-eq.fixed:36:15
   |
LL |     let _ = a => b; //~ERROR
   |               ^^ expected one of 8 possible tokens

error: expected one of `!`, `.`, `::`, `?`, `{`, or an operator, found `=>`
  --> /home/nils/projects/rust/tests/ui/parser/eq-gt-to-gt-eq.fixed:42:13
   |
LL |     match a => b { //~ERROR
   |     -----   ^^ expected one of `!`, `.`, `::`, `?`, `{`, or an operator
   |     |
   |     while parsing this `match` expression

error: aborting due to 2 previous errors
------------------------------------------

looks like it doesn't apply the fix properly for all the cases, only for some.

[sjwang05]

Thanks for the help, and sorry for dragging my feet on this--things have been keeping me pretty busy for the past few weeks. I've updated the recovery code + test output to catch more cases while hopefully keeping false positives low.

@rustbot review

[estebank]

r? @estebank

@bors r+

[bors]

📌 Commit 97cf1c8 has been approved by estebank

It is now in the queue for this repository.

[bors]

⌛ Testing commit 97cf1c8 with merge a861c89...

[bors]

☀️ Test successful - checks-actions
Approved by: estebank
Pushing a861c89 to master...

[rust-timer]

Finished benchmarking commit (a861c89): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-1.8%, -0.5%]	4
Improvements ✅ (secondary)	-0.9%	[-1.0%, -0.7%]	2
All ❌✅ (primary)	-0.9%	[-1.8%, -0.5%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.827s -> 670.98s (0.02%)
Artifact size: 312.33 MiB -> 312.28 MiB (-0.01%)