Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: notify #t-rustdoc Zulip stream on backport nominations #116957

Conversation

fmease
Copy link
Member

@fmease fmease commented Oct 19, 2023

In July '23, it was decided to handle rustdoc-specific backport nominations in t-rustdoc meetings going forward (Zulip announcement). However, t-rustdoc meetings are far too infrequent for them to address nominations on time (contrary to the weekly t-compiler meetings).

Hence GuillaumeGomez and I came to the conclusion that {beta,stable}-nominated rustdoc PRs should be dealt with on a case by case basis, e.g. on Zulip.

This PR attempts to partially automate this process. Sadly, triagebot is not quite as flexible has I've hoped. Blocked on triagebot improvements (see the FIXMEs in this PR). (Fixed in rust-lang/triagebot#1791).

r? GuillaumeGomez

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2023
@fmease fmease added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Oct 19, 2023
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR just to show my support as I think this is a very nice add! Please ping me once the other blockers have been solved.

@Urgau
Copy link
Member

Urgau commented Oct 19, 2023

Maybe instead of hijacking the beta-nominated Nominated for backporting to the compiler in the beta channel. label rustdoc could use it's own label beta-rustdoc-nominated ?
This would have the advantage of being clearer about how should be responsible for the backport but also may avoid many unnecessary ping as many PRs have both T-compiler and T-rustdoc labels.

EDIT: Same for I-nominated which should have a rustdoc variant I-rustdoc-nominated (like I-types-nominated Nominated for discussion during a types team meeting. for the Types team)

@fmease
Copy link
Member Author

fmease commented Oct 19, 2023

Hmm, I'm not super convinced that we need to introduce rustdoc-{beta,stable}-{nominated,accepted} (whatever the naming). I think it would needlessly complicate the backporting process as T-release members would have to remember to not only look for {beta,stable}-accepted but also for rustdoc-{beta,stable}-accepted. It's not the end of the world but I'd say it can be avoided.

There are only 7 T-{rustdoc,compiler}beta-accepted PRs out of 77 T-rustdocbeta-accepted PRs which amounts to 9.1%, meaning not that frequent (obviously not accounting for rejected nominations here). We could also update triagebot to support exclude_labels = ["T-compiler"] for notify-zulip hooks if we wanted to rule this out anyway.

Although the idea of creating I-rustdoc-nominated is pretty good on its own. While we could teach rustdoc reviewers to add I-rustdoc-nominated to {beta,stable}-nominated PRs, personally speaking I much prefer automation if possible.

@Urgau
Copy link
Member

Urgau commented Oct 20, 2023

I'm not proposing to introduce beta-rustdoc-accepted just the nominated variants {stable,beta}-rustdoc-nominated as {beta,stable}-accepted is already IMO agnostic.

@Mark-Simulacrum
Copy link
Member

T-release looks for both nominated and accepted labels, any changes here are somewhat painful (especially since backports are currently manual, and expressing the necessary combined query in GitHub would be... difficult).

You can read more about the process here - https://forge.rust-lang.org/release/backporting.html

So even just the nominated labels changing would be enough to lead to additional pain for the release team.

@fmease fmease removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2023
@bors

This comment was marked as outdated.

@fmease fmease force-pushed the meta-notify-rustdoc-zulip-on-backport-nominations branch from 12108d2 to 4d1db4d Compare April 14, 2024 23:03
@rustbot

This comment was marked as outdated.

@fmease fmease force-pushed the meta-notify-rustdoc-zulip-on-backport-nominations branch from 4d1db4d to 75123db Compare April 14, 2024 23:18
@fmease fmease added rla-silenced Silences rust-log-analyzer postings to the PR it's added on. and removed rla-silenced Silences rust-log-analyzer postings to the PR it's added on. labels Apr 14, 2024
@rust-lang rust-lang deleted a comment from rustbot Apr 14, 2024
@fmease fmease force-pushed the meta-notify-rustdoc-zulip-on-backport-nominations branch from 75123db to 02ba04a Compare April 14, 2024 23:21
@rust-lang rust-lang deleted a comment from rustbot Apr 14, 2024
@rust-lang rust-lang deleted a comment from rustbot Apr 14, 2024
@rust-lang rust-lang deleted a comment from rustbot Apr 14, 2024
@fmease fmease force-pushed the meta-notify-rustdoc-zulip-on-backport-nominations branch from 02ba04a to ec045f6 Compare April 15, 2024 17:55
@rust-lang rust-lang deleted a comment from rustbot Apr 15, 2024
@fmease
Copy link
Member Author

fmease commented Apr 15, 2024

I've created a triagebot patch here: rust-lang/triagebot#1791. If it gets accepted it will unblock this PR. Merged.

@fmease fmease changed the title [blocked] meta: notify #t-rustdoc Zulip stream on backport nominations meta: notify #t-rustdoc Zulip stream on backport nominations Apr 16, 2024
@fmease fmease removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Apr 16, 2024
@fmease fmease added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2024
@fmease fmease marked this pull request as ready for review April 16, 2024 13:14
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this (again)! 😄

triagebot.toml Show resolved Hide resolved
@fmease fmease force-pushed the meta-notify-rustdoc-zulip-on-backport-nominations branch 4 times, most recently from 9f2d282 to 1953e9e Compare April 16, 2024 14:58
@fmease fmease force-pushed the meta-notify-rustdoc-zulip-on-backport-nominations branch from 1953e9e to 8f3d7fe Compare April 16, 2024 15:42
@fmease
Copy link
Member Author

fmease commented Apr 17, 2024

PR has been approved.
@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Apr 17, 2024

📌 Commit 8f3d7fe has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2024
RalfJung added a commit to RalfJung/rust that referenced this pull request Apr 17, 2024
…n-backport-nominations, r=GuillaumeGomez

meta: notify #t-rustdoc Zulip stream on backport nominations

In July '23, it was decided to handle rustdoc-specific backport nominations in t-rustdoc meetings going forward ([Zulip announcement](https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/T-rustdoc.20backports/near/374828518)). However, t-rustdoc meetings are far too infrequent for them to address nominations on time (contrary to the weekly t-compiler meetings).

Hence GuillaumeGomez and I came to the conclusion that {beta,stable}-nominated rustdoc PRs should be dealt with on a case by case basis, e.g. on Zulip.

This PR attempts to partially automate this process. ~~Sadly, `triagebot` is not quite as flexible has I've hoped. Blocked on `triagebot` improvements (see the `FIXME`s in this PR).~~ (Fixed in rust-lang/triagebot#1791).

r? GuillaumeGomez
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2024
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#116957 (meta: notify #t-rustdoc Zulip stream on backport nominations)
 - rust-lang#122201 (Document overrides of `clone_from()` in core/std)
 - rust-lang#122723 (Use same file permissions for ar_archive_writer as the LLVM archive writer)
 - rust-lang#124030 (interpret: pass MemoryKind to adjust_alloc_base_pointer)
 - rust-lang#124037 (Don't ascend into parent bodies when collecting stmts for possible return suggestion)
 - rust-lang#124049 (Stabilize `const_io_structs`)
 - rust-lang#124062 (Add another expression to weird-exprs.rs)
 - rust-lang#124066 (Don't error on subtyping of equal types)
 - rust-lang#124073 (Remove libc from rust_get_test_int uses)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d7d1070 into rust-lang:master Apr 17, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2024
Rollup merge of rust-lang#116957 - fmease:meta-notify-rustdoc-zulip-on-backport-nominations, r=GuillaumeGomez

meta: notify #t-rustdoc Zulip stream on backport nominations

In July '23, it was decided to handle rustdoc-specific backport nominations in t-rustdoc meetings going forward ([Zulip announcement](https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/T-rustdoc.20backports/near/374828518)). However, t-rustdoc meetings are far too infrequent for them to address nominations on time (contrary to the weekly t-compiler meetings).

Hence GuillaumeGomez and I came to the conclusion that {beta,stable}-nominated rustdoc PRs should be dealt with on a case by case basis, e.g. on Zulip.

This PR attempts to partially automate this process. ~~Sadly, `triagebot` is not quite as flexible has I've hoped. Blocked on `triagebot` improvements (see the `FIXME`s in this PR).~~ (Fixed in rust-lang/triagebot#1791).

r? GuillaumeGomez
@fmease fmease deleted the meta-notify-rustdoc-zulip-on-backport-nominations branch April 17, 2024 18:36
@fmease fmease added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants