Add #[inline] to small functions in core #116583

saethlin · 2023-10-09T22:26:16Z

I'm adding a new case to the definition of cross-crate-inlinable; we know that making the definition too broad causes huge regressions in incremental builds. So implementing broader heuristics as a machine-applicable lint means that I can x fix --stage 1 library/core to apply the new heuristic just to the standard library. I expect that applying the broader heuristic just to the standard library will have a different effect than applying the change globally.

saethlin · 2023-10-09T22:26:35Z

@bors try @rust-timer queue

bors · 2023-10-09T22:27:44Z

⌛ Trying commit e50157c with merge fcd818f...

Add #[inline] to small functions in core Where "small" is strictly defined as optimized_mir with 5 or less statements and no calls. I've also applied that heuristic recursively; applying it once causes some functions to become eligible for MIR inlining bring other functions under the threshold. r? `@ghost`

bors · 2023-10-09T23:39:50Z

☀️ Try build successful - checks-actions
Build commit: fcd818f (fcd818f02de2a6a6d33020458f6d94f413203287)

rust-timer · 2023-10-10T01:37:03Z

Finished benchmarking commit (fcd818f): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[0.4%, 13.0%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.2%]	4
Improvements ✅ (secondary)	-13.7%	[-39.2%, -0.8%]	3
All ❌✅ (primary)	1.9%	[-0.4%, 13.0%]	9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	5.1%	[4.3%, 5.9%]	2
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-3.7%	[-8.4%, -1.3%]	6
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-1.5%	[-8.4%, 5.9%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	5.5%	[1.0%, 13.6%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-1.5%, -1.0%]	2
Improvements ✅ (secondary)	-9.4%	[-34.8%, -0.7%]	4
All ❌✅ (primary)	2.8%	[-1.5%, 13.6%]	5

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.6%]	38
Regressions ❌ (secondary)	0.0%	[0.0%, 0.1%]	7
Improvements ✅ (primary)	-0.3%	[-0.9%, -0.0%]	53
Improvements ✅ (secondary)	-0.5%	[-1.4%, -0.0%]	76
All ❌✅ (primary)	-0.1%	[-0.9%, 0.6%]	91

Bootstrap: 627.383s -> 626.833s (-0.09%)
Artifact size: 270.83 MiB -> 270.65 MiB (-0.07%)

saethlin · 2023-10-10T21:53:35Z

I'm going to try a slightly different approach just to see what happens- this time I'm adding #[inline] to non-generic functions that do not have a Call or Assert terminator.

saethlin · 2023-10-10T22:14:02Z

@bors try @rust-timer queue

bors · 2023-10-10T22:15:12Z

⌛ Trying commit 69b3155 with merge b1ac082...

Add #[inline] to small functions in core Where "small" is strictly defined as optimized_mir with 5 or less statements and no calls. I've also applied that heuristic recursively; applying it once causes some functions to become eligible for MIR inlining which brings other functions under the threshold. r? `@ghost`

bors · 2023-10-10T23:28:01Z

☀️ Try build successful - checks-actions
Build commit: b1ac082 (b1ac0828e77c4a41854e681dee17f9498d770ac8)

rust-timer · 2023-10-11T01:04:56Z

Finished benchmarking commit (b1ac082): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.4%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-1.1%, -0.3%]	7
Improvements ✅ (secondary)	-1.0%	[-1.3%, -0.3%]	23
All ❌✅ (primary)	-0.6%	[-1.1%, 0.4%]	9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.9%	[1.6%, 5.7%]	6
Regressions ❌ (secondary)	0.9%	[0.8%, 1.0%]	3
Improvements ✅ (primary)	-5.4%	[-12.4%, -0.1%]	3
Improvements ✅ (secondary)	-0.8%	[-1.1%, -0.5%]	2
All ❌✅ (primary)	0.8%	[-12.4%, 5.7%]	9

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	2
Improvements ✅ (secondary)	-1.1%	[-1.5%, -0.8%]	11
All ❌✅ (primary)	-1.1%	[-1.1%, -1.1%]	2

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.4%]	44
Regressions ❌ (secondary)	0.0%	[0.0%, 0.1%]	7
Improvements ✅ (primary)	-0.2%	[-0.6%, -0.0%]	34
Improvements ✅ (secondary)	-0.5%	[-0.6%, -0.0%]	74
All ❌✅ (primary)	-0.1%	[-0.6%, 0.4%]	78

Bootstrap: 626.852s -> 625.243s (-0.26%)
Artifact size: 270.87 MiB -> 270.69 MiB (-0.07%)

bors · 2023-11-04T17:28:43Z

⌛ Trying commit 9c3c8ef with merge d11ea83...

Add #[inline] to small functions in core I'm adding a new case to the definition of cross-crate-inlinable; we know that making the definition too broad causes huge regressions in incremental builds. So implementing broader heuristics as a machine-applicable lint means that I can `x fix --stage 1 library/core` to apply the new heuristic just to the standard library. I expect that applying the broader heuristic just to the standard library will have a different effect than applying the change globally.

bors · 2023-11-04T18:52:11Z

☀️ Try build successful - checks-actions
Build commit: d11ea83 (d11ea836c21d66e88c00ecb5a33d37760b06f1bd)

rust-timer · 2023-11-05T09:35:32Z

Finished benchmarking commit (d11ea83): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.2%, 3.7%]	41
Regressions ❌ (secondary)	3.6%	[0.2%, 6.9%]	7
Improvements ✅ (primary)	-2.4%	[-11.7%, -0.2%]	88
Improvements ✅ (secondary)	-3.4%	[-25.6%, -0.1%]	179
All ❌✅ (primary)	-1.3%	[-11.7%, 3.7%]	129

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[0.4%, 7.6%]	16
Regressions ❌ (secondary)	2.9%	[0.6%, 6.4%]	9
Improvements ✅ (primary)	-2.1%	[-7.1%, -0.5%]	11
Improvements ✅ (secondary)	-3.3%	[-7.8%, -1.1%]	12
All ❌✅ (primary)	0.8%	[-7.1%, 7.6%]	27

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.0%	[0.7%, 4.5%]	18
Regressions ❌ (secondary)	6.0%	[4.6%, 7.1%]	4
Improvements ✅ (primary)	-4.1%	[-12.6%, -0.4%]	46
Improvements ✅ (secondary)	-6.0%	[-24.6%, -1.3%]	90
All ❌✅ (primary)	-2.4%	[-12.6%, 4.5%]	64

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.1%, 8.8%]	53
Regressions ❌ (secondary)	5.7%	[0.5%, 8.8%]	6
Improvements ✅ (primary)	-2.6%	[-6.5%, -0.1%]	89
Improvements ✅ (secondary)	-4.2%	[-11.9%, -0.5%]	93
All ❌✅ (primary)	-1.1%	[-6.5%, 8.8%]	142

Bootstrap: 635.521s -> 654.274s (2.95%)
Artifact size: 304.34 MiB -> 304.99 MiB (0.21%)

saethlin · 2023-11-05T23:10:03Z

That looks like it might be moving in a good direction? Notably the big improvements are all in helloworld so I think the report looks better than the real-world impact would be.
@bors try @rust-timer queue

bors · 2023-11-05T23:11:14Z

⌛ Trying commit 4edca85 with merge 79d9fa0...

Add #[inline] to small functions in core I'm adding a new case to the definition of cross-crate-inlinable; we know that making the definition too broad causes huge regressions in incremental builds. So implementing broader heuristics as a machine-applicable lint means that I can `x fix --stage 1 library/core` to apply the new heuristic just to the standard library. I expect that applying the broader heuristic just to the standard library will have a different effect than applying the change globally.

bors · 2023-11-06T00:38:28Z

☀️ Try build successful - checks-actions
Build commit: 79d9fa0 (79d9fa061f39758953a7eb7a805ce2aeaf88f7da)

rust-timer · 2023-11-06T16:08:56Z

Finished benchmarking commit (79d9fa0): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.2%, 8.3%]	88
Regressions ❌ (secondary)	1.9%	[0.4%, 3.6%]	14
Improvements ✅ (primary)	-2.0%	[-5.1%, -0.5%]	11
Improvements ✅ (secondary)	-1.1%	[-2.0%, -0.2%]	44
All ❌✅ (primary)	1.0%	[-5.1%, 8.3%]	99

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[0.4%, 5.7%]	21
Regressions ❌ (secondary)	2.4%	[1.2%, 3.8%]	11
Improvements ✅ (primary)	-1.8%	[-3.7%, -0.5%]	6
Improvements ✅ (secondary)	-3.3%	[-8.3%, -0.7%]	5
All ❌✅ (primary)	1.7%	[-3.7%, 5.7%]	27

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[0.4%, 9.5%]	43
Regressions ❌ (secondary)	2.3%	[0.7%, 3.4%]	11
Improvements ✅ (primary)	-2.1%	[-3.7%, -0.6%]	10
Improvements ✅ (secondary)	-1.8%	[-2.4%, -1.3%]	21
All ❌✅ (primary)	1.7%	[-3.7%, 9.5%]	53

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.0%	[0.1%, 19.0%]	103
Regressions ❌ (secondary)	1.3%	[0.0%, 2.8%]	19
Improvements ✅ (primary)	-1.1%	[-3.7%, -0.1%]	25
Improvements ✅ (secondary)	-1.4%	[-2.9%, -0.0%]	11
All ❌✅ (primary)	1.4%	[-3.7%, 19.0%]	128

Bootstrap: 637.169s -> 642.023s (0.76%)
Artifact size: 304.52 MiB -> 304.70 MiB (0.06%)

saethlin · 2023-11-06T16:18:32Z

Wow that is not the direction I expected.

Emit #[inline] on derive(Debug) Breaking out part of rust-lang#116583 (comment) r? `@ghost`

…ercote Emit #[inline] on derive(Debug) While working on rust-lang#116583 I noticed that the `cross_crate_inlinable` query identifies a lot of derived `Debug` impls as a MIR body that's little more than a call, which suggests they may be a good candidate for `#[inline]`. So here I've implemented that change specifically. It seems to provide a nice improvement to build times.

saethlin · 2024-01-21T23:35:39Z

I'm not actually planning to move this PR forward; this was an experiment that resulted in adding #[inline] to derived Debug impls. I don't think there's much else to be gained here.

A lint that suggests #[inline] is a decent idea, but if I could figure out how to write that lint well I would also be able to improve cross_crate_inlinable and obviate the lint.

saethlin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Oct 9, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 9, 2023

saethlin removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 9, 2023

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 10, 2023

saethlin force-pushed the inline-small-core-fns branch from e50157c to 69b3155 Compare October 10, 2023 21:52

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 10, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 11, 2023

saethlin force-pushed the inline-small-core-fns branch from 69b3155 to ab949b8 Compare October 11, 2023 01:22

saethlin removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 11, 2023

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 4, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 5, 2023

saethlin force-pushed the inline-small-core-fns branch from 9c3c8ef to 4edca85 Compare November 5, 2023 22:59

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 5, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 6, 2023

saethlin mentioned this pull request Nov 8, 2023

Emit #[inline] on derive(Debug) #117727

Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 8, 2023

Auto merge of rust-lang#117727 - saethlin:inline-derived-fmt, r=<try>

bdd5a9a

Emit #[inline] on derive(Debug) Breaking out part of rust-lang#116583 (comment) r? `@ghost`

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 8, 2023

Auto merge of rust-lang#117727 - saethlin:inline-derived-fmt, r=<try>

bd37a3c

Emit #[inline] on derive(Debug) Breaking out part of rust-lang#116583 (comment) r? `@ghost`

saethlin added 4 commits November 10, 2023 20:00

Emit a lint for small functions without #[inline]

8c48d03

Run

9b0d03f

Run

8a8d6fd

Run

20e1c0e

saethlin force-pushed the inline-small-core-fns branch from 4edca85 to 20e1c0e Compare November 11, 2023 04:07

saethlin closed this Jan 21, 2024

saethlin deleted the inline-small-core-fns branch January 21, 2024 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add #[inline] to small functions in core #116583

Add #[inline] to small functions in core #116583

saethlin commented Oct 9, 2023 •

edited

Loading

saethlin commented Oct 9, 2023

This comment has been minimized.

bors commented Oct 9, 2023

This comment has been minimized.

bors commented Oct 9, 2023

This comment has been minimized.

rust-timer commented Oct 10, 2023

saethlin commented Oct 10, 2023

This comment has been minimized.

saethlin commented Oct 10, 2023

This comment has been minimized.

bors commented Oct 10, 2023

bors commented Oct 10, 2023

This comment has been minimized.

rust-timer commented Oct 11, 2023

bors commented Nov 4, 2023

bors commented Nov 4, 2023

This comment has been minimized.

rust-timer commented Nov 5, 2023

saethlin commented Nov 5, 2023

This comment has been minimized.

bors commented Nov 5, 2023

bors commented Nov 6, 2023

This comment has been minimized.

rust-timer commented Nov 6, 2023

saethlin commented Nov 6, 2023

saethlin commented Jan 21, 2024

Add #[inline] to small functions in core #116583

Add #[inline] to small functions in core #116583

Conversation

saethlin commented Oct 9, 2023 • edited Loading

saethlin commented Oct 9, 2023

This comment has been minimized.

bors commented Oct 9, 2023

This comment has been minimized.

bors commented Oct 9, 2023

This comment has been minimized.

rust-timer commented Oct 10, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

saethlin commented Oct 10, 2023

This comment has been minimized.

saethlin commented Oct 10, 2023

This comment has been minimized.

bors commented Oct 10, 2023

bors commented Oct 10, 2023

This comment has been minimized.

rust-timer commented Oct 11, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

bors commented Nov 4, 2023

bors commented Nov 4, 2023

This comment has been minimized.

rust-timer commented Nov 5, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

saethlin commented Nov 5, 2023

This comment has been minimized.

bors commented Nov 5, 2023

bors commented Nov 6, 2023

This comment has been minimized.

rust-timer commented Nov 6, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

saethlin commented Nov 6, 2023

saethlin commented Jan 21, 2024

saethlin commented Oct 9, 2023 •

edited

Loading