[perf] Do not reuse internal TokenStream in proc_macro::TokenStream#116488
[perf] Do not reuse internal TokenStream in proc_macro::TokenStream#116488petrochenkov wants to merge 1 commit intorust-lang:masterfrom
TokenStream in proc_macro::TokenStream#116488Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[perf] Do not reuse internal `TokenStream` in `proc_macro::TokenStream` Use a separate type instead, so that we need to convert from one `TokenStream` to another and back on proc macro boundaries. I want to check how much it affects performance. This PR also implements the suggestion to censor token jointness at proc macro boundary from rust-lang#114571 (since we now have such a boundary). This PR is also semi-related to rust-lang#101419. I don't like the result and will likely close this after the perf test.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (5a750ec): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 622.801s -> 623.308s (0.08%) |
Use a separate type instead, so that we need to convert from one
TokenStreamto another and back on proc macro boundaries.I want to check how much it affects performance.
This PR also implements the suggestion to censor token jointness at proc macro boundary from #114571 (since we now have such a boundary).
This PR is also somewhat related to #101419.
I don't like the result and will likely close this after the perf test.