Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply structured suggestion that allows test to work since 1.64 #116244

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

estebank
Copy link
Contributor

Close #73497.

@rustbot
Copy link
Collaborator

rustbot commented Sep 28, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2023
@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 11, 2023
@b-naber
Copy link
Contributor

b-naber commented Oct 12, 2023

Can't we just move that test to a different directory?

@bors
Copy link
Contributor

bors commented Oct 23, 2023

☔ The latest upstream changes (presumably #117087) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Copy link
Contributor Author

@b-naber done

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@b-naber
Copy link
Contributor

b-naber commented Nov 14, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 14, 2023

📌 Commit aae391c has been approved by b-naber

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#116244 (Apply structured suggestion that allows test to work since 1.64)
 - rust-lang#117686 (Build pre-coroutine-transform coroutine body on error)
 - rust-lang#117834 (target_feature: make it more clear what that 'Option' means)
 - rust-lang#117893 (Suggest dereferencing the LHS for binops such as `&T == T`)
 - rust-lang#117911 (Fix some typos)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 00ba7fc into rust-lang:master Nov 15, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 15, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2023
Rollup merge of rust-lang#116244 - estebank:issue-73497, r=b-naber

Apply structured suggestion that allows test to work since 1.64

Close rust-lang#73497.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account for type param in '_ constraint for returned trait suggestion
5 participants