Stabilize `extended_varargs_abi_support` #116161

Soveu · 2023-09-25T19:32:27Z

I think that is everything? If there is any documentation regarding extern and/or varargs to correct, let me know, some quick greps suggest that there might be none.

Tracking issue: #100189

rustbot · 2023-09-25T19:32:34Z

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

compiler/rustc_feature/src/active.rs

Soveu · 2023-09-25T19:36:23Z

@rustbot label F-extended_varargs_abi_support

kadiwa4 · 2023-09-25T22:16:47Z

compiler/rustc_feature/src/accepted.rs

@@ -160,6 +160,9 @@ declare_features! (
    (accepted, explicit_generic_args_with_impl_trait, "1.63.0", Some(83701), None),
    /// Allows arbitrary expressions in key-value attributes at parse time.
    (accepted, extended_key_value_attributes, "1.54.0", Some(78835), None),
+    /// Allows using `efiapi`, `aapcs`, `sysv64` and `win64` as calling
+    /// convention for functions with varargs.
+    (accepted, extended_varargs_abi_support, "1.65.0", Some(100189), None),


use CURRENT_RUSTC_VERSION instead of a version number here

tgross35 · 2023-10-05T23:04:49Z

Tracking issue: #100189

bors · 2023-10-16T17:19:11Z

☔ The latest upstream changes (presumably #116550) made this pull request unmergeable. Please resolve the merge conflicts.

Soveu · 2023-11-21T22:13:47Z

@wesleywiser

bors · 2023-12-11T15:05:09Z

☔ The latest upstream changes (presumably #118823) made this pull request unmergeable. Please resolve the merge conflicts.

apiraino · 2024-02-22T10:42:33Z

r? compiler

compiler/rustc_feature/src/accepted.rs

Nadrieril · 2024-02-22T14:04:23Z

I'm on vacation for a few days :)
r? compiler

cjgillot · 2024-03-03T14:56:53Z

Not completely sure which team should be nominated for stabilization, so labeling both in doubt.

pnkfelix · 2024-03-07T15:58:12Z

Just to add on to @cjgillot 's comment above: @wesleywiser and I could not remember earlier today whether T-lang wants to own FCP'ing changes like this that are restricted to extending the set of calling-conventions (i.e. the conv in extern "conv" fn foo(...)), which is largely a detail about what platforms one is interoperating with, and not about changing the expressiveness of the Rust language as a whole in the abstract.

(My own gut reaction is that T-compiler is a more natural owner for this than T-lang, but I wasn't certain and so it seems best to let the nomination stand and let the two teams duke it out.)

apiraino · 2024-03-14T14:59:01Z

Removing the T-compiler nomination until after T-lang discussed this. Feel free to re-add T-compiler!

@rustbot label -I-compiler-nominated

Soveu · 2024-11-27T21:26:23Z

@bors r- seems to have failed in #133542 (comment)

Yeah, it is this change... already pushed a corrected version

tgross35 · 2024-11-27T21:28:25Z

@bors r=cjgillot

bors · 2024-11-27T21:28:27Z

📌 Commit 685f189 has been approved by cjgillot

It is now in the queue for this repository.

ehuss · 2024-11-27T22:32:33Z

Can you please post a PR to update the documentation? I assume it would go in https://github.com/rust-lang/reference/blob/master/src/types/function-pointer.md.

traviscross · 2024-11-27T22:48:08Z

@bors r-

We shouldn't merge this until there is an accepted Reference PR.

traviscross · 2024-11-30T02:37:00Z

@rustbot labels -S-blocked
@bors r=cjgillot

There's an approved Reference PR now (rust-lang/reference#1687 (review)), so this is good to go.

bors · 2024-11-30T02:37:02Z

📌 Commit 685f189 has been approved by cjgillot

It is now in the queue for this repository.

Stabilize `extended_varargs_abi_support` I think that is everything? If there is any documentation regarding `extern` and/or varargs to correct, let me know, some quick greps suggest that there might be none. Tracking issue: rust-lang#100189

Rollup of 10 pull requests Successful merges: - rust-lang#116161 (Stabilize `extended_varargs_abi_support`) - rust-lang#132750 ([AIX] handle libunwind native_libs) - rust-lang#133488 (tests: Add regression test for self referential structs with cow as last field) - rust-lang#133569 (Bump `ruzstd` to 0.7.3) - rust-lang#133585 (Do not call `extern_crate` on current trait on crate mismatch errors) - rust-lang#133587 (Fix target_feature handling in freg of LoongArch inline assembly) - rust-lang#133599 (Add `+forced-atomics` feature to esp32s2 no_std target) - rust-lang#133620 (Simplify hir_typeck_pass_to_variadic_function) - rust-lang#133623 (Improve span handling in `parse_expr_bottom`.) - rust-lang#133625 (custom MIR: add doc comment for debuginfo) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116161 - Soveu:varargs2, r=cjgillot Stabilize `extended_varargs_abi_support` I think that is everything? If there is any documentation regarding `extern` and/or varargs to correct, let me know, some quick greps suggest that there might be none. Tracking issue: rust-lang#100189

rustbot assigned wesleywiser Sep 25, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 25, 2023

Soveu mentioned this pull request Sep 25, 2023

Tracking Issue for extended_varargs_abi_support #100189

Open

3 tasks

Noratrieb reviewed Sep 25, 2023

View reviewed changes

compiler/rustc_feature/src/active.rs Outdated Show resolved Hide resolved

rustbot added the F-extended_varargs_abi_support `#![feature(extended_varargs_abi_support)]` label Sep 25, 2023

Soveu force-pushed the varargs2 branch from d6dfef5 to 04b4b10 Compare September 25, 2023 19:41

This comment has been minimized.

Sign in to view

kadiwa4 reviewed Sep 25, 2023

View reviewed changes

nicholasbishop mentioned this pull request Nov 4, 2023

Tracking issue for RFC 2137: Support defining C-compatible variadic functions in Rust #44930

Open

3 tasks

Soveu force-pushed the varargs2 branch from 04b4b10 to 0ece12c Compare November 21, 2023 19:19

rustbot assigned Nadrieril and unassigned wesleywiser Feb 22, 2024

Skgland reviewed Feb 22, 2024

View reviewed changes

compiler/rustc_feature/src/accepted.rs Outdated Show resolved Hide resolved

rustbot assigned cjgillot and unassigned Nadrieril Feb 22, 2024

cjgillot added I-lang-nominated Nominated for discussion during a lang team meeting. I-compiler-nominated Nominated for discussion during a compiler team meeting. labels Mar 3, 2024

rustbot removed the I-compiler-nominated Nominated for discussion during a compiler team meeting. label Mar 14, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 27, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 27, 2024

tgross35 added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 27, 2024

rustbot mentioned this pull request Nov 27, 2024

Tracking issue for release notes of #116161: Stabilize extended_varargs_abi_support #133552

Open

3 tasks

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 27, 2024

traviscross added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Nov 27, 2024

Soveu mentioned this pull request Nov 29, 2024

Update function-pointer.md for stabilization of extended_varargs_abi_support rust-lang/reference#1687

Merged

rustbot removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Nov 30, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 30, 2024

This was referenced Nov 30, 2024

Rollup of 9 pull requests #133657

Closed

Rollup of 10 pull requests #133658

Merged

bors merged commit dd99f11 into rust-lang:master Nov 30, 2024
6 checks passed

rustbot added this to the 1.85.0 milestone Nov 30, 2024

HTGAzureX1212 mentioned this pull request Dec 4, 2024

uefi-raw: Use efiapi After Stabilization rust-osdev/uefi-rs#1490

Closed

2 tasks

Ayush1325 mentioned this pull request Dec 24, 2024

Use variadic function signatures r-efi/r-efi#87

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize `extended_varargs_abi_support` #116161

Stabilize `extended_varargs_abi_support` #116161

Soveu commented Sep 25, 2023 •

edited by jieyouxu

Loading

rustbot commented Sep 25, 2023

Soveu commented Sep 25, 2023

This comment has been minimized.

kadiwa4 Sep 25, 2023

tgross35 commented Oct 5, 2023

bors commented Oct 16, 2023

Soveu commented Nov 21, 2023

bors commented Dec 11, 2023

apiraino commented Feb 22, 2024

Nadrieril commented Feb 22, 2024

cjgillot commented Mar 3, 2024

pnkfelix commented Mar 7, 2024 •

edited

Loading

apiraino commented Mar 14, 2024

Soveu commented Nov 27, 2024

tgross35 commented Nov 27, 2024

bors commented Nov 27, 2024

ehuss commented Nov 27, 2024

traviscross commented Nov 27, 2024 •

edited

Loading

traviscross commented Nov 30, 2024

bors commented Nov 30, 2024

Stabilize extended_varargs_abi_support #116161

Stabilize extended_varargs_abi_support #116161

Conversation

Soveu commented Sep 25, 2023 • edited by jieyouxu Loading

rustbot commented Sep 25, 2023

Soveu commented Sep 25, 2023

This comment has been minimized.

kadiwa4 Sep 25, 2023

Choose a reason for hiding this comment

tgross35 commented Oct 5, 2023

bors commented Oct 16, 2023

Soveu commented Nov 21, 2023

bors commented Dec 11, 2023

apiraino commented Feb 22, 2024

Nadrieril commented Feb 22, 2024

cjgillot commented Mar 3, 2024

pnkfelix commented Mar 7, 2024 • edited Loading

apiraino commented Mar 14, 2024

Soveu commented Nov 27, 2024

tgross35 commented Nov 27, 2024

bors commented Nov 27, 2024

ehuss commented Nov 27, 2024

traviscross commented Nov 27, 2024 • edited Loading

traviscross commented Nov 30, 2024

bors commented Nov 30, 2024

Stabilize `extended_varargs_abi_support` #116161

Stabilize `extended_varargs_abi_support` #116161

Soveu commented Sep 25, 2023 •

edited by jieyouxu

Loading

pnkfelix commented Mar 7, 2024 •

edited

Loading

traviscross commented Nov 27, 2024 •

edited

Loading