-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make unknown/renamed/removed lints passed via command line respect lint levels #115387
Conversation
This demonstrates the current behavior of adding lint form the command line. generally the lint levels are ignored as the current implementation unconditionally emit errors for those lints.
(rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
7404b6a
to
dc675de
Compare
This comment has been minimized.
This comment has been minimized.
dc675de
to
a11805a
Compare
r? @estebank If you've got time to review this :) |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (5d62ab8): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 630.224s -> 629.427s (-0.13%) |
What does this PR try to resolve?
This is the implementation of MCP rust-lang/compiler-team#667.
Also fixes #74722
How should we test and review this PR?
Additional information
A bit unfortunate this brings some diagnostic duplications. I am not familiar enough with the codebase to eliminiate them. Will appreciate if someone can give pointers. (Or, we can defer this to follow-up PRs?)