Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reassign sparc-unknown-none-elf to tier 3 #115075

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Reassign sparc-unknown-none-elf to tier 3 #115075

merged 1 commit into from
Aug 22, 2023

Conversation

workingjubilee
Copy link
Member

It should never have been moved to tier 2. It is a new platform and the maintainer has agreed to do tier 3 maintenance for it, not tier 2.

r? @jonathanpallant

@workingjubilee
Reassign sparc-unknown-none-elf to tier 3
89e6597 
It should never have been moved to tier 2.
It is a new platform and the maintainer has agreed
to do tier 3 maintenance for it, not tier 2.
@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2023

Failed to set assignee to jonathanpallant: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2023
@workingjubilee
Copy link
Member Author

Uh.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 21, 2023

📌 Commit 89e6597 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2023
@workingjubilee workingjubilee linked an issue Aug 21, 2023 that may be closed by this pull request
platform support has sparc-unknown-none-elf on the wrong tier #115063
Closed
@compiler-errors
Copy link
Member

For the record: #113535 says "Tier 3"

@workingjubilee
Copy link
Member Author

Indeed, it's just an ordering failure.

@workingjubilee
Copy link
Member Author

This is machine-checkable, probably.

@bors
Copy link
Contributor

bors commented Aug 22, 2023

⌛ Testing commit 89e6597 with merge b4d09f3...

@bors
Copy link
Contributor

bors commented Aug 22, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing b4d09f3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 22, 2023
@bors bors merged commit b4d09f3 into rust-lang:master Aug 22, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 22, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b4d09f3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.782s -> 634.91s (0.02%)
Artifact size: 347.03 MiB -> 346.98 MiB (-0.01%)

@workingjubilee workingjubilee deleted the retier-sparc-none branch August 22, 2023 21:00
@workingjubilee workingjubilee mentioned this pull request Aug 26, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 26, 2023
@matthiaskrgr
Rollup merge of rust-lang#115237 - workingjubilee:fixup-baremetal-spa…
b578e86 
…rc-platform-support-tabulation, r=GuillaumeGomez

Fixup sparc-unknown-none-elf table spacing

Missed this in rust-lang#115075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

platform support has sparc-unknown-none-elf on the wrong tier
5 participants
@workingjubilee @rustbot @compiler-errors @bors @rust-timer