Go into more detail about panicking in drop.

[kpreid]

This patch was sitting around in my drafts. I don't recall the motivation, but I think it was someone expressing confusion over “will likely abort” (since, in fact, a panicking drop not caused by dropping while panicking will predictably not abort).

I hope that the new text will leave people well-informed about why not to panic and when it is reasonable to panic.

[rustbot]

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

Seems OK.

@bors r+

[bors]

📌 Commit 2bccf1e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

⌛ Testing commit 2bccf1e with merge f320f42...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f320f42 to master...

[rust-timer]

Finished benchmarking commit (f320f42): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.5%	[3.5%, 3.5%]	1
Regressions ❌ (secondary)	4.4%	[4.4%, 4.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-4.2%, -1.3%]	3
All ❌✅ (primary)	3.5%	[3.5%, 3.5%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.022s -> 631.802s (0.12%)
Artifact size: 316.05 MiB -> 316.10 MiB (0.01%)