Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed *const [type error] does not implement the Copy trait #114752

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fixed *const [type error] does not implement the Copy trait #114752

merged 1 commit into from
Aug 14, 2023

Conversation

RickleAndMortimer
Copy link
Contributor

Removes "error: arguments for inline assembly must be copyable" when moving an unknown type

Fixes: #113788

@rustbot
Copy link
Collaborator

rustbot commented Aug 12, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 12, 2023
@asquared31415
Copy link
Contributor

asquared31415 commented Aug 12, 2023 •
edited
Loading

This should include tests that make sure that the issue is fixed, and that this doesn't regress.

@jackh726
Copy link
Member

See comments above

@jackh726 jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2023
@RickleAndMortimer
Copy link
Contributor Author

This should include tests that make sure that the issue is fixed, and that this doesn't regress.

I have the code in the original issue as a test case. I'd like to know what other test cases I could add to this PR and how to write them up.

compiler-errors
compiler-errors reviewed Aug 14, 2023
View reviewed changes
tests/ui/asm/issue-113788.rs Show resolved Hide resolved
compiler/rustc_hir_analysis/src/check/intrinsicck.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/check/intrinsicck.rs Outdated Show resolved Hide resolved
tests/ui/asm/issue-113788.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

Can you squash this into one commit please? Usually for things like this where you're fixing nits and making it pass, there's no reason to maintain commit history 😸

fee1-dead
fee1-dead reviewed Aug 14, 2023
View reviewed changes
src/llvm-project Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This submodule update doesn't seem to be right.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 14, 2023

📌 Commit cac7c12 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2023
@RickleAndMortimer
Copy link
Contributor Author

RickleAndMortimer commented Aug 14, 2023 •
edited
Loading

Thank you @compiler-errors @jackh726 @asquared31415 @fee1-dead for your feedback!

@matthiaskrgr matthiaskrgr mentioned this pull request Aug 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2023
@bors
Auto merge of rust-lang#114821 - matthiaskrgr:rollup-bahtz9m, r=matth…
f960bdf 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#114745 (Make Const more useful in smir)
 - rust-lang#114752 (fixed *const [type error] does not implement the Copy trait)
 - rust-lang#114760 (DebugInfo: Updates test cases that add method declarations.)
 - rust-lang#114815 (Update books)
 - rust-lang#114817 (Remove unnecessary FIXME)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 378c2fd into rust-lang:master Aug 14, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 14, 2023
@RickleAndMortimer RickleAndMortimer deleted the issue-113788-fix branch October 2, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fee1-dead fee1-dead fee1-dead left review comments

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

Inline asm: *const [type error] does not implement the Copy trait
8 participants
@RickleAndMortimer @rustbot @asquared31415 @jackh726 @rust-log-analyzer @compiler-errors @bors @fee1-dead