rustc: Move features from Session to GlobalCtxt

[petrochenkov]

Removes one more piece of mutable state.
Follow up to #114622.

The rule I used for passing feature in function signatures:

• if a crate already depends on rustc_middle, then Session is replaced with TyCtxt
• otherwise session and features are passed as a pair sess: &Session, features: &Features

The code in rustc_lint is ultimately used for implementing a trait from rustc_expand, so it also doesn't use tcx despite the dependency on rustc_middle.

[rustbot]

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[davidtwco]

@bors r+

[bors]

📌 Commit 7353c96 has been approved by davidtwco

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7353c96 with merge d2c5db06389ecc1784dae0b622b0862b2f7a5e29...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing d2c5db06389ecc1784dae0b622b0862b2f7a5e29 to master...

[bors]

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

[rust-timer]

Finished benchmarking commit (d2c5db06389ecc1784dae0b622b0862b2f7a5e29): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	3.5%	[2.4%, 6.0%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-5.0%, -1.5%]	8
All ❌✅ (primary)	2.7%	[2.7%, 2.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.358s -> 633.497s (0.18%)

[cjgillot]

@bors retry : Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

[bors]

⌛ Testing commit 7353c96 with merge 5f3abbc...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 5f3abbc to master...

[rust-timer]

Finished benchmarking commit (5f3abbc): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.2%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[0.8%, 6.0%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-5.2%, -1.7%]	10
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.852s -> 634.77s (-0.01%)