Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a sparc-unknown-none-elf target. #113535
Add a sparc-unknown-none-elf target. #113535
Changes from 2 commits
d30294e
4bccf83
9efc683
3f3a855
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-critical: Does using
cargo +nightly build -Zbuild-std=core,alloc,compiler_builtins --release
work? If so, it may be preferable in lieu of building a compiler with such support, if the v8 instructions and Leon3 scheduling is a significant difference, as that will rebuild std with the relevant instructions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only tried with build-std=core but that's how I've been using it (rather than having the toolchain build the libcore in advance).
I suppose you could make this sparcv8-unknown-none-elf because I think SPARC V7 stuff is very very niche at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, then I think we should document a recommendation to use
-Zbuild-std
if that's what the target's maintainer is preferentially using. ^^; No opinion on the arch version question.