Replace mk_const with Const::new_x methods
#113325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to set assignee to
|
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes might have occurred in exhaustiveness checking cc @Nadrieril |
lcnr
reviewed
Jul 4, 2023
Co-authored-by: lcnr <[email protected]>
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
|
@bors p=10 (this will merge conflict with any PR that constructs new |
|
⌛ Testing commit d3cd406 with merge 7cec65b61e5a0999aed541907411a4d2bda6ee9a... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d3cd406 with merge 8941f4b329aa93e0464fdd087c0edd2d83364272... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d3cd406 with merge f8e2c12b9857d6c0d18f415ad5ca86a891784184... |
|
@bors retry yield to #113274 (comment) - this takes about 2 hours to run so we're less than a quarter through, MIPS segfaults about half the time so expected value is to merge it first |
|
lol i think bors didn't like that my comment was so long @bors retry |
|
@bors retry |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (f20afcc): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 653.846s -> 653.078s (-0.12%) |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 5, 2023
…r=oli-obk Move `ty::ConstKind` to `rustc_type_ir` Needed this in another PR for custom debug impls, and this will also be required to move the new solver into a separate crate that does not use `TyCtxt` so that r-a and friends can depend on the trait solver. Rebased on top of rust-lang#113325, only the second and third commits needs reviewing
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jul 5, 2023
…r=oli-obk Move `ty::ConstKind` to `rustc_type_ir` Needed this in another PR for custom debug impls, and this will also be required to move the new solver into a separate crate that does not use `TyCtxt` so that r-a and friends can depend on the trait solver. Rebased on top of rust-lang#113325, only the second and third commits needs reviewing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of rust-lang/compiler-team#616. Instead of just havign
Const::new(and nothing else I did it like this since this is more like how themk_xworks forTy, and also another PR of mine will require changing fromConst::new(toConst::new_x(anyway.r? @oli-bok