Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Strikethrough deprecated items in sidebar #113082

Closed

Conversation

Jules-Bertholet
Copy link
Contributor

Fixes #107568 by indicating deprecated items in the sidebar with strikethrough.

This is my first Rustdoc contribution, and I would appreciate guidance on how to write/where to add tests.

@rustbot label A-rustdoc-ui T-rustdoc

@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 27, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2023

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rustbot rustbot added the A-rustdoc-ui Area: Rustdoc UI (generated HTML) label Jun 27, 2023
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member

In this case, it would have been better to have wait for a decision to be reached because it's very likely that this solution will be either rejected or will be considered incomplete. And it's not great when contributors work for "nothing". :-/

I'm personally not a big fan of this approach but let's see what the rest of the team thinks about it.

cc @rust-lang/rustdoc

@bors
Copy link
Contributor

bors commented Aug 16, 2023

☔ The latest upstream changes (presumably #114905) made this pull request unmergeable. Please resolve the merge conflicts.

@notriddle
Copy link
Contributor

Consensus in the recent meeting seemed to reject this PR.

https://rust-lang.zulipchat.com/#narrow/stream/393423-t-rustdoc.2Fmeetings/topic/meeting.2004-09-2023/near/389048618

Thanks for the time, and sorry it didn't work out.

@notriddle notriddle closed this Sep 8, 2023
@Jules-Bertholet Jules-Bertholet deleted the rustdoc-deprecated branch September 8, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc: indicate deprecated items on the sidebar
6 participants