Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privacy: Type privacy lints fixes and cleanups #112670

Merged
merged 4 commits into from
Jun 29, 2023
Merged

privacy: Type privacy lints fixes and cleanups #112670

merged 4 commits into from
Jun 29, 2023

Commits on Jun 15, 2023

  1. privacy: Feature gate new type privacy lints

    @petrochenkov
    petrochenkov committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d326aed View commit details
    Browse the repository at this point in the history

  2. privacy: Remove (Non)ShallowEffectiveVis 

    Use a boolean constant parameter instead.

Also turn some methods on `DefIdVisitor` into associated constants.
    @petrochenkov
    petrochenkov committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    17edd1a View commit details
    Browse the repository at this point in the history

  3. privacy: Do not mark items reachable farther than their nominal visib… 

    …ility

This commit reverts a change made in rust-lang#111425.
It was believed that this change was necessary for implementing type privacy lints, but rust-lang#111801 showed that it was not necessary.
Quite opposite, the revert fixes some issues.
    @petrochenkov
    petrochenkov committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    95a24c6 View commit details
    Browse the repository at this point in the history

  4. privacy: Rename some variables for clarity

    @petrochenkov
    petrochenkov committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    98a86ff View commit details
    Browse the repository at this point in the history