Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy PR to test coverage test changes in CI #112514

Closed
wants to merge 1 commit into from
Closed

Dummy PR to test coverage test changes in CI #112514

wants to merge 1 commit into from

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Jun 11, 2023 •
edited
Loading

I have some changes to the coverage tests (#112300) that need to be tested on other platforms to make sure they don't break anything.

r? @ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 11, 2023
@Zalathar
Copy link
Contributor Author

As I suspected, uses_crate.rs and uses_inline_crate.rs actually work fine on Windows and Mac.

The run-make tests couldn't express this restriction, but with run-coverage I can just add an ignore-linux directive to those files and have them run in CI again.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Zalathar Zalathar mentioned this pull request Jun 12, 2023
Merged
@Dylan-DPC Dylan-DPC added the S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. label Jun 13, 2023
@bors
Copy link
Contributor

bors commented Jun 14, 2023

☔ The latest upstream changes (presumably #112418) made this pull request unmergeable. Please resolve the merge conflicts.

@Zalathar
Copy link
Contributor Author

New experiment: I've been assuming that uses_crate.rs and uses_inline_crate.rs still fail on Linux, but I want to verify whether that's actually still true.

@Zalathar
Copy link
Contributor Author

Unexpectedly, those tests now seem to pass on Linux as well: https://github.com/rust-lang/rust/actions/runs/5275751902/jobs/9541593530?pr=112514

@Zalathar
Copy link
Contributor Author

Next experiment: Check whether uses_crate.rs and uses_inline_crate.rs pass or fail on Linux on master.

This will tell me whether the failure has been magically fixed by someone else, or whether it has been magically fixed by my migration.

@Zalathar
Copy link
Contributor Author

For reference, I last saw these tests fail on Linux in #111179 (comment) .

@Zalathar
Copy link
Contributor Author

Per https://github.com/rust-lang/rust/actions/runs/5276267731/jobs/9542755469?pr=112514 , the test seems to succeed on Linux even on current master, without my migration to run-coverage.

@Zalathar
Copy link
Contributor Author

I'll do another test run on Linux (this time with no changes to bootstrap), just for good measure.

@Zalathar Zalathar force-pushed the dummy-coverage branch 3 times, most recently from 7012112 to a6b41de Compare June 15, 2023 11:32
@Zalathar Zalathar marked this pull request as draft June 15, 2023 23:44
@Zalathar
Copy link
Contributor Author

Now that I've said #112300 is ready to merge, I want to run one last cross-platform check to make sure that nothing has mysteriously broken over the last few weeks.

@bors
Copy link
Contributor

bors commented Jun 28, 2023

☔ The latest upstream changes (presumably #113105) made this pull request unmergeable. Please resolve the merge conflicts.

@Zalathar Zalathar mentioned this pull request Jul 6, 2023
Merged
@bors
Copy link
Contributor

bors commented Jul 29, 2023

☔ The latest upstream changes (presumably #114148) made this pull request unmergeable. Please resolve the merge conflicts.

@Zalathar Zalathar closed this Jul 30, 2023
@Zalathar Zalathar deleted the dummy-coverage branch July 30, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zalathar @rust-log-analyzer @bors @rustbot @Dylan-DPC