Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve document of unsafe_code lint #112260

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Improve document of unsafe_code lint #112260

merged 1 commit into from
Jun 9, 2023

Conversation

eval-exec
Copy link
Contributor

This PR add another unsafe_code lint example, want to close #111967

@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2023
@eval-exec eval-exec force-pushed the exec/fix-unsafe_code_lint branch 2 times, most recently from 5b26205 to 5aa631a Compare June 3, 2023 23:05
@eval-exec
Copy link
Contributor Author

eval-exec commented Jun 4, 2023 •
edited
Loading

The unsafe_code on this branch looks like this:
image

@eval-exec
Copy link
Contributor Author

eval-exec commented Jun 8, 2023 •
edited
Loading

@rustbot reviewer

@WaffleLapkin WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2023
@WaffleLapkin WaffleLapkin assigned WaffleLapkin and unassigned b-naber Jun 8, 2023
@eval-exec eval-exec force-pushed the exec/fix-unsafe_code_lint branch 2 times, most recently from 6e1b9c1 to 1f8814c Compare June 9, 2023 08:11
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2023
WaffleLapkin
WaffleLapkin reviewed Jun 9, 2023
View reviewed changes
compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved
compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved
@WaffleLapkin WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2023
@eval-exec eval-exec force-pushed the exec/fix-unsafe_code_lint branch 2 times, most recently from 4add537 to 1a4ebe4 Compare June 9, 2023 09:17
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@eval-exec eval-exec force-pushed the exec/fix-unsafe_code_lint branch from 1a4ebe4 to 2d6a6a8 Compare June 9, 2023 09:30
WaffleLapkin
WaffleLapkin reviewed Jun 9, 2023
View reviewed changes
compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved
compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved
@eval-exec eval-exec force-pushed the exec/fix-unsafe_code_lint branch from 2d6a6a8 to 30f84c4 Compare June 9, 2023 12:41
@eval-exec eval-exec requested a review from WaffleLapkin June 9, 2023 12:42
@WaffleLapkin
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 9, 2023

📌 Commit 30f84c4 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 9, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2023
@bors
Auto merge of rust-lang#112465 - GuillaumeGomez:rollup-gyh5buc, r=Gui…
397641f 
…llaumeGomez

Rollup of 3 pull requests

Successful merges:

 - rust-lang#112260 (Improve document of `unsafe_code` lint)
 - rust-lang#112429 ([rustdoc] List matching impls on type aliases)
 - rust-lang#112442 (Deduplicate identical region constraints in new solver)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a7f46af into rust-lang:master Jun 9, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

Document additional constructs caught by the unsafe_code lint
6 participants
@eval-exec @rustbot @rust-log-analyzer @WaffleLapkin @bors @b-naber