-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Test performance of running MIR inliner on inline(always) function calls in optimized incremental build #111804
Conversation
This comment has been minimized.
This comment has been minimized.
80a9cc1
to
13e7243
Compare
This comment has been minimized.
This comment has been minimized.
13e7243
to
1e216a6
Compare
This comment has been minimized.
This comment has been minimized.
1e216a6
to
63dcb19
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 63dcb19 with merge 2ac93540d856f9637f3654946eaacf6913e11a7f... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (2ac93540d856f9637f3654946eaacf6913e11a7f): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 643.639s -> 643.573s (-0.01%) |
@vlad20012 any updates on this? |
Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks |
Currently (#91743, #109247) MIR inliner is enabled only in non-incremental optimized builds because in incremental builds it significantly hurts compilation times. In this PR I'd like to perform several performance tests with different MIR inliner setups and try to find such a setup that improves compilation times even in incremental builds.
r? @ghost