-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document stack-protector option #111722
Document stack-protector option #111722
Conversation
Only updated `exploit-mitigations.md` to reflect that the option exists. Removed the alternatives mentioned as they are not actually implemented yet. As this is an unstable feature, should it be added to `unstable-book` also? I didn't do that because I couldn't find the tracking issue for it. (There should be one to track stabilization of the feature.)
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
I also suggest changing
to
|
r? rcvalle |
Thanks for the review @rcvalle! Will make the changes, I just want to make sure I understand them correctly: does the presence of cross-references to |
Yes, the presence of cross-references to
Note that previously there were no cross-references to |
Done! |
Thank you for your time and for working on this, @mrcnski! Much appreciated. |
@bors r+ |
@rcvalle: 🔑 Insufficient privileges: Not in reviewers |
@bors r=rcvalle |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111427 ([rustdoc][JSON] Use exclusively externally tagged enums in the JSON representation) - rust-lang#111486 (Pretty-print inherent projections correctly) - rust-lang#111722 (Document stack-protector option) - rust-lang#111761 (fix(resolve): not defined `extern crate shadow_name`) - rust-lang#111845 (Update books) - rust-lang#111851 (CFI: Fix encode_region: unexpected ReEarlyBound(0, 'a)) - rust-lang#111871 (Migrate GUI colors test to original CSS color format) r? `@ghost` `@rustbot` modify labels: rollup
Only updated
exploit-mitigations.md
to reflect that the option exists. Removed the alternatives mentioned as they are not actually implemented yet.As this is an unstable feature, should it be added to
unstable-book
also? Example. I didn't do that because I couldn't find the tracking issue for stack-protector. (There should be one to track stabilization of the feature, I think?)cc @rcvalle