Rollup of 10 pull requests #111639
Merged
Rollup of 10 pull requests #111639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentations` only apply to public items.
When constant evaluation fails because its MIR is tainted by errors, suppress note indicating that erroneous constant was used, since those errors have to be fixed regardless of the constant being used or not.
@eholk is back from vacation so he can review things again.
refactor(resolve): clean up the early error return caused by non-call closes rust-lang#109250 It seems no bad happened, r? ``@Nilstrieb``
…ics-correctly, r=Nilstrieb Recover `impl<T ?Sized>` correctly Fixes rust-lang#111327 r? ````@Nilstrieb```` but you can re-roll Alternatively, happy to close this if we're okay with just saying "sorry rust-lang#111327 is just a poor side-effect of parser ambiguity" 🤷
Document that `missing_copy_implementations` and `missing_debug_implementations` only apply to public items. I encountered rust-lang#111359 (fixed) and noticed that the documentation didn't say that it was _intended_ that `missing_debug_implementations` only applies to public items. This PR fixes that, and makes the same wording change to `missing_copy_implementations` which has the same condition. I chose the words to also be similar to `missing_docs` which already had such a remark.
…=oli-obk Suppress "erroneous constant used" for constants tainted by errors When constant evaluation fails because its MIR is tainted by errors, suppress note indicating that erroneous constant was used, since those errors have to be fixed regardless of the constant being used or not. Fixes rust-lang#110891.
…rrors fixup version placeholder for `cfi_encoding` feature Mentioned rust-lang#105452 (comment)
Add clubby789 to the bootstrap review rotation r? `````@clubby789````` - thank you for volunteering! I have been meaning for a very long time now to write up how to do reviews, but I haven't gotten around to it yet :( here is a short summary: 1. If you're not sure what the changes does or if it's ok, always feel free to ping someone else on the team, especially in the first few weeks. You can use `r? bootstrap` to get triagebot to assign someone else. 2. Bootstrap unfortunately has very few tests. Things that touch CLI or toml parsing should likely have a test in `src/bootstrap/config/tests.rs`; things that touch "core" build logic should have a test in `builder/tests.rs`, anything else kinda just slips in :( see rust-lang#102563 for ideas on how to improve the situation here. 3. "Major" changes should be documented in `src/bootstrap/CHANGELOG.md`. "Major" is up to you, but if it breaks a config option or otherwise is likely to break *someone's* build, it's probably major. If it breaks nearly *everyone*'s build, it should also update `VERSION` in `lib.rs`; this should be very rare. Please also ping me or Mark-Simulacrum for major changes (I might set up a triagebot ping for this so you don't have to remember). 4. Once you've approved the PR, tell bors it's ok - you've been contributing for a while so you know how bors works, but here's a cheatsheet just in case: https://bors.rust-lang.org Documentation about how to use bootstrap lives at https://rustc-dev-guide.rust-lang.org/building/bootstrapping.html; internal docs live in `src/bootstrap/README.md`. The latter unfortunately is not very complete.
Add more interesting nonsense to weird-exprs.rs Some cursed things rust allows that I've ran into. [The second is taken from here](https://twitter.com/Lucretiel/status/1638929955751964679)
Fixed typo Fixed typo in BTree Curser.
…wesleywiser Add eholk back to compiler-contributors reviewers ```@eholk``` is back from vacation so he can review things again. r? ```@wesleywiser```
…-Simulacrum Fix release date of 1.58.1 in release notes. This fixes the release notes to have the correct release date for 1.58.1. The [blog announcement](https://blog.rust-lang.org/2022/01/20/Rust-1.58.1.html) has the correct date and link (which is otherwise broken without this change). Closes rust-lang#94278
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 72b2716246 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced May 16, 2023
|
Finished benchmarking commit (a673ad6): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 641.487s -> 641.949s (0.07%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
impl<T ?Sized>correctly #111449 (Recoverimpl<T ?Sized>correctly)missing_copy_implementationsandmissing_debug_implementationsonly apply to public items. #111572 (Document thatmissing_copy_implementationsandmissing_debug_implementationsonly apply to public items.)cfi_encodingfeature #111605 (fixup version placeholder forcfi_encodingfeature)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup