Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] One more attempt to optimize module_children #110855

Closed
wants to merge 1 commit into from
Closed

[WIP] One more attempt to optimize module_children #110855

wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 26, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 26, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 26, 2023

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 26, 2023
@bors
Copy link
Contributor

bors commented Apr 26, 2023

⌛ Trying commit bcb29142b259bd814fc2bcbaf6ee822baeb3f959 with merge e0a7623063c188e1caa6776933658768926fc468...

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Apr 26, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Apr 26, 2023

⌛ Trying commit b3225aac103605c14d05c97f71f2276b29a79567 with merge 4226b1366b4201df1103cf204924aa92162f4523...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Apr 26, 2023

💔 Test failed - checks-actions

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2023

The Miri subtree was changed

cc @rust-lang/miri

@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Apr 27, 2023

⌛ Trying commit de64b4e with merge db3c30d65bdb5a1071f70513aed898f5b0f0a0ea...

@bors bors mentioned this pull request Apr 27, 2023
Closed
@bors
Copy link
Contributor

bors commented Apr 27, 2023

☀️ Try build successful - checks-actions
Build commit: db3c30d65bdb5a1071f70513aed898f5b0f0a0ea (db3c30d65bdb5a1071f70513aed898f5b0f0a0ea)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (db3c30d65bdb5a1071f70513aed898f5b0f0a0ea): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.9% [1.9%, 1.9%] 1
Regressions ❌
(secondary)		 3.1% [1.2%, 5.8%] 5
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.3% [-0.3%, -0.2%] 3
All ❌✅ (primary) 1.9% [1.9%, 1.9%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.8% [1.0%, 2.2%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.3% [-2.7%, -1.2%] 9
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [1.1%, 4.6%] 5
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 27, 2023
@petrochenkov petrochenkov mentioned this pull request May 3, 2023
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
@Manishearth
Rollup merge of rust-lang#111146 - petrochenkov:decident, r=compiler-…
b0198f2 
…errors

rustc_middle: Fix `opt_item_ident` for non-local def ids

Noticed while working on rust-lang#110855.
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
@Manishearth
Rollup merge of rust-lang#111146 - petrochenkov:decident, r=compiler-…
9554034 
…errors

rustc_middle: Fix `opt_item_ident` for non-local def ids

Noticed while working on rust-lang#110855.
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
@Manishearth
Rollup merge of rust-lang#111146 - petrochenkov:decident, r=compiler-…
26d0790 
…errors

rustc_middle: Fix `opt_item_ident` for non-local def ids

Noticed while working on rust-lang#110855.
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
@Manishearth
Rollup merge of rust-lang#111146 - petrochenkov:decident, r=compiler-…
48c7824 
…errors

rustc_middle: Fix `opt_item_ident` for non-local def ids

Noticed while working on rust-lang#110855.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petrochenkov @rustbot @rust-timer @bors @rust-log-analyzer @compiler-errors