Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create projection ty for const projection #110566

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Don't create projection ty for const projection #110566

merged 1 commit into from
Apr 24, 2023

Conversation

compiler-errors
Copy link
Member

Fixes #110549

@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 19, 2023
@compiler-errors
Copy link
Member Author

cc @BoxyUwU if you want to review this, though i don't think it's totally necessary if you're busy.

@cjgillot
Copy link
Contributor

r=me after rebase (WithOptConstParam is gone), except if @BoxyUwU wants to take a look.

@compiler-errors
Copy link
Member Author

fixed

@bors r=cjgillot,BoxyUwU

@bors
Copy link
Contributor

bors commented Apr 23, 2023

📌 Commit cde5bca has been approved by cjgillot,BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 24, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2023
@bors
Auto merge of rust-lang#110752 - matthiaskrgr:rollup-959s77u, r=matth…
64bcb32 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110255 (Suggest using integration tests for test crate using own proc-macro)
 - rust-lang#110514 (Remove `find_map_relevant_impl`)
 - rust-lang#110566 (Don't create projection ty for const projection)
 - rust-lang#110637 (Group some sections of our logs in github actions)
 - rust-lang#110706 (Add `intrinsics::transmute_unchecked`)
 - rust-lang#110714 (Normalize types and consts in MIR opts.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8aab707 into rust-lang:master Apr 24, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 24, 2023
@compiler-errors compiler-errors deleted the bad-projection-term branch August 11, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxyUwU BoxyUwU BoxyUwU approved these changes

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

ICE: assertion failed: (left matches right)`
5 participants
@compiler-errors @rustbot @cjgillot @bors @BoxyUwU