Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling src etc #110431

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Spelling src etc #110431

merged 1 commit into from
Apr 21, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 16, 2023

The various src/* items seem slightly disparate, so I'm doing src/* individually.

split from #110392

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2023
jsoref
jsoref commented Apr 16, 2023
View reviewed changes
Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll squash if the changes are ok

src/etc/lldb_lookup.py
return DefaultSynthteticProvider(valobj, dict)
return DefaultSyntheticProvider(valobj, dict)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only interesting part of this change. I'm assuming that uppercase doesn't imply a frozen/public symbol.

@Mark-Simulacrum
Copy link
Member

Please squash commits, r=me after that.

@jsoref
Spelling tools/compiletest
50240b3 
spelling: exactly
spelling: synthetic

Signed-off-by: Josh Soref <[email protected]>
@jsoref
Copy link
Contributor Author

jsoref commented Apr 20, 2023

@Mark-Simulacrum squashed

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 20, 2023

📌 Commit 50240b3 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2023
@bors
Copy link
Contributor

bors commented Apr 21, 2023

⌛ Testing commit 50240b3 with merge 77778e0...

@bors
Copy link
Contributor

bors commented Apr 21, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 77778e0 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 21, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 77778e0 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Apr 21, 2023
@bors bors merged commit 77778e0 into rust-lang:master Apr 21, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 21, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (77778e0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.6% [0.4%, 3.3%] 27
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.6% [0.4%, 3.3%] 27

Cycles

This benchmark run did not return any relevant results for this metric.

@jsoref jsoref deleted the spelling-src-etc branch April 21, 2023 13:03
@apiraino apiraino mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jsoref @rustbot @Mark-Simulacrum @bors @rust-timer