Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #110024

Merged
merged 15 commits into from
Apr 7, 2023
Merged

Rollup of 6 pull requests #110024

merged 15 commits into from
Apr 7, 2023

Commits on Mar 31, 2023

  1. Configuration menu
    Copy the full SHA
    6c94136 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Configuration menu
    Copy the full SHA
    6861750 View commit details
    Browse the repository at this point in the history
  2. Fix same issue in bootstrap

    thomcc committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    12dff54 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    42e38e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b904ce9 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Configuration menu
    Copy the full SHA
    00d54c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ed2dc0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    529ceee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9dbf20e View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#109806 - Zoxc:gnu-tls, r=pnkfelix

    Workaround rust-lang#109797 on windows-gnu
    
    The addition of `#[inline]` here in rust-lang#108089 caused an unrelated linking issue (rust-lang#109797). This PR removes this attribute again on Windows to avoid regressions.
    matthiaskrgr authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    b7e6973 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#109957 - fmease:fix-109905, r=petrochenkov

    diagnostics: account for self type when looking for source of unsolved type variable
    
    Fixes rust-lang#109905.
    
    When searching for the source of an unsolved infer var inside of a list of generic args, we look through the `tcx.generics_of(…).own_substs(…)` which *skips* the self type if present. However, the computed `argument_index` is later[^1] used to index into `tcx.generics_of(…).params` which may still contain the self type. In such case, we are off by one when indexing into the parameters.
    
    From now on, we account for this immediately after calling `own_substs` which keeps things local.
    
    This also fixes the wrong output in the preexisting UI test `inference/need_type_info/concrete-impl.rs` which was overlooked. It used to claim that the *type of type parameter `Self`* couldn't be inferred in `<Struct as Ambiguous<_>>::method()` which of course isn't true: `Self` equals `Struct` here, `A` couldn't be inferred.
    
    `@rustbot` label A-diagnostics
    
    [^1]: https://github.com/rust-lang/rust/blob/f98a2718141593fbb8dbad10acc537786d748156/compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs#L471
    matthiaskrgr authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    e63586f View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#109960 - thomcc:symlink-junction-buffer-ove…

    …rrun, r=ChrisDenton
    
    Fix buffer overrun in bootstrap and (test-only) symlink_junction
    
    I don't think these can be hit in practice, due to their inputs being valid paths. It's also not security-sensitive code, but just... bad vibes.
    
    I think this is still not really the right way to do this (in terms of path correctness), but is no worse than it was.
    
    r? `@ChrisDenton`
    matthiaskrgr authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    17ed06a View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#110013 - compiler-errors:non-exhaustive-pri…

    …vacy-reason, r=WaffleLapkin
    
    Label `non_exhaustive` attribute on privacy errors from non-local items
    
    Label when an ADT is `non_exhaustive` and we get a privacy error, help with confusion in a case like this:
    
    ```rust
    #[non_exhaustive]
    pub struct Foo;
    
    // other crate
    let x = Foo;
    //~^ ERROR unit struct `Foo` is private
    ```
    matthiaskrgr authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    e708189 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#110016 - GuillaumeGomez:gui-collapsed-mobil…

    …e, r=notriddle
    
    Run collapsed GUI test in mobile mode as well
    
    Extending test from rust-lang#109818 to be run on mobile as well.
    
    Part of rust-lang#66181.
    
    r? `@notriddle`
    matthiaskrgr authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    273b221 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#110022 - Ezrashaw:fix-parser-ident-regressi…

    …on, r=compiler-errors
    
    fix: fix regression in rust-lang#109203
    
    Fixes rust-lang#110014
    
    r? `@compiler-errors`
    matthiaskrgr authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    903b439 View commit details
    Browse the repository at this point in the history