Disable path trimming during graphviz output

[clubby789]

Fixes #109943

We can end up pretty-printing a path for the graphviz file without emitting a diagnostic, so disable path trimming at this point.

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

Yeah, this is fine. Full paths are possibly better than trimmed ones here... Alternatively, we could defuse the delayed good-path bug if we know that we'll be emitting a graphviz file, like all the other if conditions here:

rust/compiler/rustc_session/src/session.rs

Lines 673 to 680 in 6032700

	pub fn delay_good_path_bug(&self, msg: impl Into<DiagnosticMessage>) {
	if self.opts.unstable_opts.print_type_sizes
	|| self.opts.unstable_opts.query_dep_graph
	|| self.opts.unstable_opts.dump_mir.is_some()
	|| self.opts.unstable_opts.unpretty.is_some()
	|| self.opts.output_types.contains_key(&OutputType::Mir)
	|| std::env::var_os("RUSTC_LOG").is_some()
	{

Thoughts? Otherwise, r=me.

@bors delegate+

[bors]

✌️ @clubby789 can now approve this pull request

[clubby789]

Hmm, we can check there if we've asked for graphs on the command line but I don't see an easy way to check for the linked case, where it's being emitted due to an attribute (other than adding some is_emitting_graphviz field to the sess which doesn't sound good to me)

[compiler-errors]

Reasonable enough

@bors r+

[bors]

📌 Commit 422c330 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 422c330 with merge a412564...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing a412564 to master...

[rust-timer]

Finished benchmarking commit (a412564): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[1.5%, 1.5%]	1
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[3.4%, 3.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.7%, -2.5%]	2
All ❌✅ (primary)	-	-	0