Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old #[doc(primitive = "...")] attribute #109830

Closed

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #109443.

Since it was merged, we can now completely get rid of the old attribute.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 1, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

Hum... We should wait for a few days for a new nightly I suppose. Will rebase in 2 days then.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling memchr v2.5.0
   Compiling std v0.0.0 (/checkout/library/std)
   Compiling compiler_builtins v0.1.91
   Compiling unwind v0.0.0 (/checkout/library/unwind)
error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
  |
  |
4 | #[rustc_doc_primitive = "bool"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
   |
   |
66 | #[rustc_doc_primitive = "never"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
    |
    |
277 | #[rustc_doc_primitive = "char"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
    |
    |
401 | #[rustc_doc_primitive = "unit"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
    |
    |
463 | #[rustc_doc_primitive = "pointer"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
    |
    |
580 | #[rustc_doc_primitive = "array"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
    |
    |
781 | #[rustc_doc_primitive = "slice"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
    |
    |
873 | #[rustc_doc_primitive = "str"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
    |
    |
940 | #[rustc_doc_primitive = "tuple"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1084 | #[rustc_doc_primitive = "f32"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1150 | #[rustc_doc_primitive = "f64"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1165 | #[rustc_doc_primitive = "i8"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1171 | #[rustc_doc_primitive = "i16"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1177 | #[rustc_doc_primitive = "i32"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1183 | #[rustc_doc_primitive = "i64"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1189 | #[rustc_doc_primitive = "i128"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1195 | #[rustc_doc_primitive = "u8"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1201 | #[rustc_doc_primitive = "u16"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1207 | #[rustc_doc_primitive = "u32"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1213 | #[rustc_doc_primitive = "u64"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1219 | #[rustc_doc_primitive = "u128"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1225 | #[rustc_doc_primitive = "isize"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1235 | #[rustc_doc_primitive = "usize"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1245 | #[rustc_doc_primitive = "reference"]


error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
     |
     |
1376 | #[rustc_doc_primitive = "fn"]

error: cannot find attribute `rustc_doc_primitive` in this scope
 --> library/core/src/primitive_docs.rs:4:3
  |
  |
4 | #[rustc_doc_primitive = "bool"]

error: cannot find attribute `rustc_doc_primitive` in this scope
  --> library/core/src/primitive_docs.rs:66:3
   |
   |
66 | #[rustc_doc_primitive = "never"]

error: cannot find attribute `rustc_doc_primitive` in this scope
   --> library/core/src/primitive_docs.rs:277:3
    |
    |
277 | #[rustc_doc_primitive = "char"]

error: cannot find attribute `rustc_doc_primitive` in this scope
   --> library/core/src/primitive_docs.rs:401:3
    |
    |
401 | #[rustc_doc_primitive = "unit"]

error: cannot find attribute `rustc_doc_primitive` in this scope
   --> library/core/src/primitive_docs.rs:463:3
    |
    |
463 | #[rustc_doc_primitive = "pointer"]

error: cannot find attribute `rustc_doc_primitive` in this scope
   --> library/core/src/primitive_docs.rs:580:3
    |
    |
580 | #[rustc_doc_primitive = "array"]

error: cannot find attribute `rustc_doc_primitive` in this scope
   --> library/core/src/primitive_docs.rs:781:3
    |
    |
781 | #[rustc_doc_primitive = "slice"]

error: cannot find attribute `rustc_doc_primitive` in this scope
   --> library/core/src/primitive_docs.rs:873:3
    |
    |
873 | #[rustc_doc_primitive = "str"]

error: cannot find attribute `rustc_doc_primitive` in this scope
   --> library/core/src/primitive_docs.rs:940:3
    |
    |
940 | #[rustc_doc_primitive = "tuple"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1084:3
     |
     |
1084 | #[rustc_doc_primitive = "f32"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1150:3
     |
     |
1150 | #[rustc_doc_primitive = "f64"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1165:3
     |
     |
1165 | #[rustc_doc_primitive = "i8"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1171:3
     |
     |
1171 | #[rustc_doc_primitive = "i16"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1177:3
     |
     |
1177 | #[rustc_doc_primitive = "i32"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1183:3
     |
     |
1183 | #[rustc_doc_primitive = "i64"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1189:3
     |
     |
1189 | #[rustc_doc_primitive = "i128"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1195:3
     |
     |
1195 | #[rustc_doc_primitive = "u8"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1201:3
     |
     |
1201 | #[rustc_doc_primitive = "u16"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1207:3
     |
     |
1207 | #[rustc_doc_primitive = "u32"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1213:3
     |
     |
1213 | #[rustc_doc_primitive = "u64"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1219:3
     |
     |
1219 | #[rustc_doc_primitive = "u128"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1225:3
     |
     |
1225 | #[rustc_doc_primitive = "isize"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1235:3
     |
     |
1235 | #[rustc_doc_primitive = "usize"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1245:3
     |
     |
1245 | #[rustc_doc_primitive = "reference"]

error: cannot find attribute `rustc_doc_primitive` in this scope
    --> library/core/src/primitive_docs.rs:1376:3
     |
     |
1376 | #[rustc_doc_primitive = "fn"]

error: could not compile `core` due to 50 previous errors
Build completed unsuccessfully in 0:00:05
cat: /tmp/toolstate/toolstates.json: No such file or directory

@GuillaumeGomez GuillaumeGomez deleted the remove-doc-primitive branch April 24, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants