Upgrade libuv with an OSX build system fix #10921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows building of libuv for android with a host OS of OSX.
bors
added a commit
that referenced
this pull request
Dec 14, 2013
This allows building of libuv for android with a host OS of OSX.
This was referenced Dec 31, 2013
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 2, 2014
1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1 2. Needs android ndk r9(not r9b) and latest android sdk 3. Needs some device list update on sdk for apk build. 4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 3, 2014
1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1 2. Needs android ndk r9(not r9b) and latest android sdk 3. Needs some device list update on sdk for apk build. 4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 3, 2014
1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1 2. Needs android ndk r9(not r9b) and latest android sdk 3. Needs some device list update on sdk for apk build. 4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 3, 2014
1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1 2. Needs android ndk r9(not r9b) and latest android sdk 3. Needs some device list update on sdk for apk build. 4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 3, 2014
1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1 2. Needs android ndk r9(not r9b) and latest android sdk 3. Needs some device list update on sdk for apk build. 4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…v/servo/PR_android); r=kmcallister 1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1 2. Needs android ndk r9(not r9b) and latest android sdk 3. Needs some device list update on sdk for apk build. 4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade. Source-Repo: https://github.com/servo/servo Source-Revision: 90f44738a4c6daaa0df323fe19783bd28aa724d7 UltraBlame original commit: f1fc8649cbcb082aa07bd04071809d0b1db6e648
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 30, 2019
…v/servo/PR_android); r=kmcallister 1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1 2. Needs android ndk r9(not r9b) and latest android sdk 3. Needs some device list update on sdk for apk build. 4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade. Source-Repo: https://github.com/servo/servo Source-Revision: 90f44738a4c6daaa0df323fe19783bd28aa724d7 UltraBlame original commit: f1fc8649cbcb082aa07bd04071809d0b1db6e648
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…v/servo/PR_android); r=kmcallister 1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1 2. Needs android ndk r9(not r9b) and latest android sdk 3. Needs some device list update on sdk for apk build. 4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade. Source-Repo: https://github.com/servo/servo Source-Revision: 90f44738a4c6daaa0df323fe19783bd28aa724d7 UltraBlame original commit: f1fc8649cbcb082aa07bd04071809d0b1db6e648
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
…earth Add `needless_if` lint first off: Sorry about the large diff. Seems a ton of tests do this (understandably so). this is basically everything I wanted in rust-lang#10868, while it doesn't lint *all* unnecessary empty blocks, it lints needless if statements; which are basically the crux of the issue (for me) anyway. I've committed code that includes this far too many times 😅 hopefully clippy can help me out soon closes rust-lang#10868 changelog: New lint [`needless_if`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building of libuv for android with a host OS of OSX.