Rollup of 9 pull requests #109015
Merged
Rollup of 9 pull requests #109015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fixed by simply using the currently registered target in the current session. We need to use it because of target json that are not by design included in the rustc list of targets.
Move __thread_local_inner macro in crate::thread::local to crate::sys. Currently, the tidy check does not fail for `library/std/src/thread/local.rs` even though it contains platform specific code. This is beacause target_family did not exist at the time the tidy checks were written [1]. [1]: rust-lang#105861 (comment) Signed-off-by: Ayush Singh <[email protected]>
Split the __thread_local_inner macro to make it more readable. Also move everything to crate::sys::common::thread_local. Signed-off-by: Ayush Singh <[email protected]>
This is a regression from rust-lang#94857.
The current error message is _really_ confusing.
This allows removing all the platform-dependent code from `library/std/src/thread/local.rs` and `library/std/src/thread/mod.rs` Signed-off-by: Ayush Singh <[email protected]>
serialize `q` (`itemPaths`) sparsely overall 4% reduction in search index size
Fix `vec_deque::Drain` FIXME In my original `VecDeque` rewrite, I didn't use `VecDeque::slice_ranges` in `Drain::as_slices`, even though that's basically the exact use case for `slice_ranges`. The reason for this was that a `VecDeque` wrapped in a `Drain` actually has its length set to `drain_start`, so that there's no potential use after free if you `mem::forget` the `Drain`. I modified `slice_ranges` to accept an explicit `len` parameter instead, which it now uses to bounds check the given range. This way, `Drain::as_slices` can use `slice_ranges` internally instead of having to basically just copy paste the `slice_ranges` code. Since `slice_ranges` is just an internal helper function, this shouldn't change the user facing behavior in any way.
…=jsha rustdoc: sort deprecated items lower in search closes rust-lang#98759 ### Screenshots `i32::MAX` show sup above `std::i32::MAX` and `core::i32::MAX`  If just searching for `min`, the deprecated results show up far below other things:  one page later  ~~And, as you can see, the "Deprecation planned" message shows up in the search results. The same is true for fully-deprecated items like `mem::uninitialized`: ~~ Edit: the deprecation message change was removed from this PR. Only the sorting is changed.
~~){kind=link}
Add note when matching token with nonterminal The current error message is _really_ confusing. The implementation is slightly hacky, but not that much more hacky than all this nonterminal stuff.. r? ``@petrochenkov``
…,jsha,GuillaumeGomez rustdoc: Migrate `document_item_info` to Askama https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/rustdoc.20allocations.20are.20slow Hoping to piece-by-piece migrate things to template. Had a few failed attempts at more complex parts of the code, so this is just a start.
…uillaumeGomez rustdoc: Migrate sidebar rendering to Askama cc rust-lang#108757 Renders the sidebar for documentation using an Askama template
…bilee Move __thread_local_inner to sys Move `__thread_local_inner` macro in `crate::thread::local` to `crate::sys`. Initially, I was thinking about removing this macro completely, but I could not find a way to create the generic statics without macros, so in the end, I just moved to code around. This probably will need a rebase once rust-lang#108917 is merged r? ``@workingjubilee``
…-obk Honor current target when checking conditional compilation values This is fixed by simply using the currently registered target in the current session. We need to use it because of target json that are not by design included in the rustc list of targets. Fixes rust-lang#108941
…errors Directly construct Inherited in typeck. Using `InheritedBuilder` + a closure does not seem necessary any more. + a few opportunistic simplifications to typeck entry point.
… r=petrochenkov rustdoc: Don't crash on `crate` references in blocks This is a regression from rust-lang#94857.
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=9 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit e12ba73 with merge 48f048a53d955eeb5b449d86d645fcaecbf39c73... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: e350fe4e60 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 11, 2023
|
Finished benchmarking commit (67e1681): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
vec_deque::DrainFIXME #106276 (Fixvec_deque::DrainFIXME)document_item_infoto Askama #108757 (rustdoc: Migratedocument_item_infoto Askama)cratereferences in blocks #108988 (rustdoc: Don't crash oncratereferences in blocks)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup