Force to use the stage 2 compiler when config.download_rustc is set #108866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ozkanonur (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
onur-ozkan
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
thank you for the fix, please consider suggestion from @albertlarsan68, I will queue the PR after that
Kohei316
requested review from
albertlarsan68 and
onur-ozkan
and removed request for
albertlarsan68
|
can you squash your commits into single commit? |
onur-ozkan
reviewed
Mar 7, 2023
src/bootstrap/lib.rs
Outdated
Comment on lines
1212
to
1216
| /// Tests whether the `compiler` compiling for `target` should be forced to | ||
| /// use a stage2 compiler instead. | ||
| /// | ||
| /// If we use a downloaded, pre-compiled version of rustc it should be forced to | ||
| /// use a stage2 compiler. |
There was a problem hiding this comment.
Suggested change
| /// Tests whether the `compiler` compiling for `target` should be forced to | |
| /// use a stage2 compiler instead. | |
| /// | |
| /// If we use a downloaded, pre-compiled version of rustc it should be forced to | |
| /// use a stage2 compiler. | |
| /// Checks whether the `compiler` compiling for `target` should be forced to | |
| /// use a stage2 compiler instead. | |
| /// | |
| /// When we download the pre-compiled version of rustc it should be forced to | |
| /// use a stage2 compiler. |
…nload_rustc is set
onur-ozkan
approved these changes
Mar 7, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#108460 (migrate `rustc_hir_analysis` to session diagnostic [Part Two]) - rust-lang#108581 (Add a new config flag, dist.include-mingw-linker.) - rust-lang#108583 (Account for binders correctly when adding default RPITIT method assumption) - rust-lang#108783 (Sync rustc_codegen_gcc 2023/03/04) - rust-lang#108793 (Append to existing `PYTHONPATH` in compiletest instead of overwriting) - rust-lang#108822 (Remove references to PassManagerBuilder) - rust-lang#108866 (Force to use the stage 2 compiler when config.download_rustc is set) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
This PR may have caused a failure running tests for some users: #109286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108768