Rollup of 8 pull requests #107650

compiler-errors · 2023-02-03T22:15:25Z

Successful merges:

Make const/fn return params more suggestable #106887 (Make const/fn return params more suggestable)
Add type alias for raw OS errors #107519 (Add type alias for raw OS errors)
Replace ConstFnMutClosure with const closures #107551 ( Replace ConstFnMutClosure with const closures )
Retry opening proc-macro DLLs a few times on Windows. #107595 (Retry opening proc-macro DLLs a few times on Windows.)
Replace nbsp in all rustdoc code blocks #107615 (Replace nbsp in all rustdoc code blocks)
Intern external constraints in new solver #107621 (Intern external constraints in new solver)
loudly tell people when they change Cargo.lock #107631 (loudly tell people when they change Cargo.lock)
Clarifying that .map() returns None if None. #107632 (Clarifying that .map() returns None if None.)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Co-Authored-By: David Tolnay <[email protected]>

…, r=oli-obk Make const/fn return params more suggestable Bumps const item type suggestions to MachineApplicable (fixes rust-lang#106843), also replaces FnDef with FnPtr items in return type suggestions to make more things suggestable. r? diagnostics

Add type alias for raw OS errors Implement rust-lang/libs-team#173. `@rustbot` label +S-waiting-on-ACP +T-libs-api

…elper, r=oli-obk Replace `ConstFnMutClosure` with const closures Also fixes a parser bug. cc `@oli-obk` for compiler changes

…loading, r=petrochenkov Retry opening proc-macro DLLs a few times on Windows. On Windows, the compiler [sometimes](https://users.rust-lang.org/t/error-loadlibraryexw-failed/77603) fails with the message `error: LoadLibraryExW failed` when trying to load a proc-macro crate. The error seems to occur intermittently, similar to rust-lang#86929, however, it seems to be almost impossible to reproduce outside of CI environments and thus very hard to debug. The fact that the error only occurs intermittently makes me think that this is a timing related issue. This PR is an attempt to mitigate the issue by letting the compiler retry a few times when encountering this specific error (which resolved the issue described in rust-lang#86929).

…umeGomez Replace nbsp in all rustdoc code blocks Based on rust-lang#106125 by `@dtolnay` — this PR fixes the line wrapping bug. Fixes rust-lang#106098. This makes code copyable from rustdoc rendered documentation into a Rust source file.

…nstraints, r=lcnr Intern external constraints in new solver Makes the query response `Copy`, fixing a few FIXMEs.

…mpiler-errors loudly tell people when they change `Cargo.lock` It keeps happening that people accidentally commit changes to `Cargo.lock` and then have to be told by a reviewer to undo this. I've also seen cases where PRs are merged that accidentally changed `Cargo.lock` during a rebase.. I figure that purposeful changes to `Cargo.lock` are likely rarer than these accidental ones?

Clarifying that .map() returns None if None. Fix rust-lang#107622

compiler-errors · 2023-02-03T22:15:45Z

@bors r+ rollup=never p=1

bors · 2023-02-03T22:15:47Z

📌 Commit 13bd75f has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2023-02-03T22:16:06Z

⌛ Testing commit 13bd75f with merge 6cc8a565e0128d5deef986200873db86febc16ea...

bors · 2023-02-03T22:24:22Z

💔 Test failed - checks-actions

compiler-errors · 2023-02-03T22:37:35Z

@bors retry

bors · 2023-02-03T22:37:57Z

⌛ Testing commit 13bd75f with merge 886b2c3...

bors · 2023-02-04T02:08:25Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 886b2c3 to master...

rust-timer · 2023-02-04T02:10:41Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#107632	c5b3bb000d31f620ce79545e6bd92c3a9eb23dfe
#107631	3521401835c796dd4fee3016125beef24b630580
#107621	5075e2af4f96bbf1e807aa5e36e951d1df92a661
#107615	750e8839355ab95d7265cd5363f7d95bf7b5b7e7
#107595	e7302f7680c4fedd4d1867222b47314fefc693ce
#107551	f8535db4a238c28dc483adc03ad8b3a6337b4513
#107519	d0bfa4844bca41e6bec45cd0f0c181ed6a648d6a
#106887	a5298d50f67ad01e67f4aad75abf94077a7550b6

previous master: 658fad6c55

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-02-04T03:29:14Z

Finished benchmarking commit (886b2c3): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.4%	[0.3%, 6.2%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.4%	[-7.4%, -7.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	2.4%	[1.6%, 3.5%]	17
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	1
Improvements ✅ (secondary)	-1.8%	[-1.8%, -1.8%]	1
All ❌✅ (primary)	1.1%	[-0.0%, 2.2%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.7%, 3.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-4.4%, -3.2%]	2
All ❌✅ (primary)	-	-	0

rust-log-analyzer · 2023-02-04T17:13:51Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:ac593985615ec2ede58e132d2e21d2b1cbd6127c)
##[warning]Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/ac593985615ec2ede58e132d2e21d2b1cbd6127c'. Error: Resource temporarily unavailable (codeload.github.com:443)
##[warning]Back off 26.81 seconds before retry.
##[warning]Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/ac593985615ec2ede58e132d2e21d2b1cbd6127c'. Error: Resource temporarily unavailable (codeload.github.com:443)
##[warning]Back off 24.923 seconds before retry.
##[error]Resource temporarily unavailable (codeload.github.com:443)

pnkfelix · 2023-02-07T18:06:07Z

the vast bulk regressions are on six variations of secondary benchmarks match-stress
and all of those appear to to have all been resolved by follow-on PR Remove OnHit callback from query caches. #107667
marking as triaged.

@rustbot label: +perf-regression-triaged

joboet and others added 18 commits January 31, 2023 17:23

std: add type alias for raw OS errors

42cc28a

Implement rust-lang/libs-team#173.

fix parser mistaking const closures for const item

679dde7

Retry opening proc-macro DLLs a few times on Windows.

227b285

loudly tell people when Cargo.lock changes

b83078f

Replace ConstFnMutClosure with const closures

b886a4d

Replace nbsp in all rustdoc code blocks

784665d

Co-Authored-By: David Tolnay <[email protected]>

Clarifying that .map() returns None if None.

c2b65ff

nit fixed

b384692

intern external constraints

41883fd

Make const/fn return params more suggestable

0b5941a

Rollup merge of rust-lang#107519 - joboet:raw_os_error_ty, r=Amanieu

beb5cc9

Add type alias for raw OS errors Implement rust-lang/libs-team#173. `@rustbot` label +S-waiting-on-ACP +T-libs-api

Rollup merge of rust-lang#107551 - fee1-dead-contrib:rm_const_fnmut_h…

e99e05d

…elper, r=oli-obk Replace `ConstFnMutClosure` with const closures Also fixes a parser bug. cc `@oli-obk` for compiler changes

Rollup merge of rust-lang#107621 - compiler-errors:intern-external-co…

72599c6

…nstraints, r=lcnr Intern external constraints in new solver Makes the query response `Copy`, fixing a few FIXMEs.

Rollup merge of rust-lang#107632 - ameknite:issue-107622-fix, r=jyn514

13bd75f

Clarifying that .map() returns None if None. Fix rust-lang#107622

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 3, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 4, 2023

bors merged commit 886b2c3 into rust-lang:master Feb 4, 2023

rustbot added this to the 1.69.0 milestone Feb 4, 2023

This was referenced Feb 4, 2023

rustdoc: Break bounds if they are too long #107298

Closed

rustdoc: change trait bound formatting #102842

Merged

rustbot added the perf-regression Performance regression. label Feb 4, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label Feb 7, 2023

compiler-errors deleted the rollup-4pntchf branch August 11, 2023 20:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #107650

Rollup of 8 pull requests #107650

compiler-errors commented Feb 3, 2023

compiler-errors commented Feb 3, 2023

bors commented Feb 3, 2023

bors commented Feb 3, 2023

bors commented Feb 3, 2023

compiler-errors commented Feb 3, 2023

bors commented Feb 3, 2023

bors commented Feb 4, 2023

rust-timer commented Feb 4, 2023

rust-timer commented Feb 4, 2023

rust-log-analyzer commented Feb 4, 2023

pnkfelix commented Feb 7, 2023 •

edited

Loading

Rollup of 8 pull requests #107650

Rollup of 8 pull requests #107650

Conversation

compiler-errors commented Feb 3, 2023

compiler-errors commented Feb 3, 2023

bors commented Feb 3, 2023

bors commented Feb 3, 2023

bors commented Feb 3, 2023

compiler-errors commented Feb 3, 2023

bors commented Feb 3, 2023

bors commented Feb 4, 2023

rust-timer commented Feb 4, 2023

rust-timer commented Feb 4, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

rust-log-analyzer commented Feb 4, 2023

pnkfelix commented Feb 7, 2023 • edited Loading

pnkfelix commented Feb 7, 2023 •

edited

Loading