Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport reverts to fix thin archive reading for 1 68 beta #107609

Merged
merged 5 commits into from
Feb 8, 2023
Merged

Backport reverts to fix thin archive reading for 1 68 beta #107609

merged 5 commits into from
Feb 8, 2023

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Feb 2, 2023 •
edited
Loading

This is a backport of PR #107360 aimed at beta.

cc #107162, #107334 and google/shaderc-rs#133

@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 2, 2023
@pnkfelix pnkfelix mentioned this pull request Feb 2, 2023
Merged
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Feb 6, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Feb 6, 2023

📌 Commit 77565f7 has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2023
@bors
Copy link
Contributor

bors commented Feb 7, 2023

⌛ Testing commit 77565f7 with merge ac81a5bb6c925a4d56f80d718d36ef96175d15c6...

@bors
Copy link
Contributor

bors commented Feb 7, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2023
@cuviper
Copy link
Member

cuviper commented Feb 7, 2023

I think we also need #107574 on beta.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 8, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@cuviper
Copy link
Member

cuviper commented Feb 8, 2023

I've cherry-picked rust-lang/rust-clippy#10265 and #107574 here as well, since we've already applied those to stable in #107743.

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Feb 8, 2023

📌 Commit 0e31fdb has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2023
@bors
Copy link
Contributor

bors commented Feb 8, 2023

⌛ Testing commit 0e31fdb with merge 5a6594b...

@bors
Copy link
Contributor

bors commented Feb 8, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 5a6594b to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 8, 2023
@bors bors merged commit 5a6594b into rust-lang:beta Feb 8, 2023
@rustbot rustbot added this to the 1.68.0 milestone Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TaKO8Ki TaKO8Ki

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
9 participants
@pnkfelix @rustbot @TaKO8Ki @bors @cuviper @rust-log-analyzer @bjorn3 @Manishearth @compiler-errors