Rollup of 12 pull requests #107536

GuillaumeGomez · 2023-01-31T22:38:55Z

Successful merges:

Include both md and yaml ICE ticket templates #106898 (Include both md and yaml ICE ticket templates)
Clean up eslint annotations and remove unused JS function #107331 (Clean up eslint annotations and remove unused JS function)
small refactor to new projection code #107348 (small refactor to new projection code)
rustdoc: update Source Serif 4 from 4.004 to 4.005 #107354 (rustdoc: update Source Serif 4 from 4.004 to 4.005)
avoid needless checks #107412 (avoid needless checks)
Improve enum checks #107467 (Improve enum checks)
Track bound types like bound regions #107486 (Track bound types like bound regions)
rustdoc: remove unused CSS from .setting-check #107491 (rustdoc: remove unused CSS from .setting-check)
Edition micro refactor #107508 (Edition micro refactor)
PointeeInfo is advisory only #107525 (PointeeInfo is advisory only)
rustdoc: stop making unstable items transparent #107527 (rustdoc: stop making unstable items transparent)
Replace unwrap with ? in TcpListener doc #107535 (Replace unwrap with ? in TcpListener doc)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

* Existing compilers link to the md version * The YAML version field for the backtrace *doesn't let us paste a full backtrace* * We will need the YAML version in order to be able to submit reports once we start storing the backtrace to disk

Version 4.005 was released on 2023-01-20.

These rules were needed for the mobile-style switches, but those were removed in 0f3ae62

Fixes rust-lang#93393

… r=Mark-Simulacrum Include both md and yaml ICE ticket templates * Existing compilers link to the md version * The YAML version field for the backtrace *doesn't let us paste a full backtrace* * We will need the YAML version in order to be able to submit reports once we start storing the backtrace to disk Follow up to rust-lang#106831. Reaction to rust-lang#106874, which made me realize that *really* long backtraces are rejected by GitHub Forms. A single backtrace won't hit this, but ICEs sometimes compound.

…ddle Clean up eslint annotations and remove unused JS function Thanks to rust-lang#107177 I realized that some eslint annotations might be unneeded so I cleaned them up. I also removed the unused function while we wait for rust-lang#107177 to be updated. r? ``@notriddle``

…-errors small refactor to new projection code extract `eq_term_and_make_canonical_response` into a helper function which also is another guarantee that the expected term does not influence candidate selection for projections. also change `evaluate_all(vec![single_goal])` to use `evaluate_goal`. the second commit now also adds a `debug_assert!` to `evaluate_goal`.

…llaumeGomez rustdoc: update Source Serif 4 from 4.004 to 4.005 [Version 4.005](https://github.com/adobe-fonts/source-serif/releases/tag/4.005R) was released on 2023-01-20.

…iser avoid needless checks

Improve enum checks Some light refactoring.

…, r=oli-obk Track bound types like bound regions When we instantiate bound types into placeholder types, we throw away the names for some reason. These names are particularly useful for error reporting once we have `for<T>` binders. r? types

… r=GuillaumeGomez rustdoc: remove unused CSS from `.setting-check` These rules were needed for the mobile-style switches, but those were removed in 0f3ae62

`Edition` micro refactor r? ``@oli-obk``

PointeeInfo is advisory only rust-lang#107248 fixed PointeeInfo being used in ways that don't actually work. Hopefully this comments helps avoid such issues in the future. Cc ``@eddyb``

…r=GuillaumeGomez rustdoc: stop making unstable items transparent Fixes rust-lang#93393

Replace unwrap with ? in TcpListener doc The example in TcpListener doc returns `std::io::Result<()>` but the code inside the function uses `unwrap()` instead of `?`.

GuillaumeGomez · 2023-01-31T22:39:10Z

@bors r+ rollup=never p=8

bors · 2023-01-31T22:39:12Z

📌 Commit adc3f8a has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2023-02-01T01:15:07Z

⌛ Testing commit adc3f8a with merge ad8e1dc...

bors · 2023-02-01T04:53:22Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing ad8e1dc to master...

rust-timer · 2023-02-01T04:56:44Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#107535	60387d2ba7e857fbbb790729a12a32a90ff0a128
#107527	c638b69a42b849328f55ef88250951e721c058f1
#107525	60d9c44ace4decd70fc0e119a33b44350009b431
#107508	020b12407624b2b2e6bab69108953eb573e2369c
#107491	0d57f23c51189df2c45734955813d5055a7237e8
#107486	cbdf96a6019b3c38b8521f2de4aed1e48798c21e
#107467	178a24673a1fb71f573f97ec2cefc0837ee99460
#107412	1efbb1cff492001212be0ce6699f884fe14ab6bb
#107354	6fb623605a31e1d696cde6425d10f019828e4749
#107348	6cbf4860e933542b06c37637d729c81485e93208
#107331	c487c9be648c28786430a279c4e656c43bb120c0
#106898	0f26af8f0124745ed0165c387afc0d8f52fc4a1a

previous master: 5b6ed253c4

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-02-01T06:12:10Z

Finished benchmarking commit (ad8e1dc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-3.2%	[-3.2%, -3.2%]	1
Improvements ✅ (secondary)	-2.5%	[-3.3%, -1.9%]	3
All ❌✅ (primary)	-3.2%	[-3.2%, -3.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

estebank and others added 30 commits January 15, 2023 03:33

Include both md and yaml ICE ticket templates

f706c3c

* Existing compilers link to the md version * The YAML version field for the backtrace *doesn't let us paste a full backtrace* * We will need the YAML version in order to be able to submit reports once we start storing the backtrace to disk

small refactor to new projection code

9c3fe58

assert that solver results are stable

85e6f38

rustdoc: update Source Serif 4 from 4.004 to 4.005

167fbbc

Version 4.005 was released on 2023-01-20.

add comment to rustdoc.css on updating filename suffixes

1c3fc9d

avoid needless checks

a8418c0

Replace enum ==s with matches where it makes sense

fd649a3

Use Mutability::{is_mut, is_not}

4d75f61

Replace some _ == _ || _ == _s with matches!(_, _ | _)s

f1d273c

Track bound types like bound regions

0e98a16

rustdoc: remove unused CSS from .setting-check

31c14f6

These rules were needed for the mobile-style switches, but those were removed in 0f3ae62

Review changes

340414e

Use Edition methods a bit more

fd5774a

Document rust_2015 methods

5d90413

Don't do .edition().rust_*()

03158f4

Don't accept Edition by ref

ef6b583

Clean up eslint annotations and remove unused JS function

0a1f14a

PointeeInfo is advisory only

c8e8d6e

rustdoc: stop making unstable items transparent

f75b350

Fixes rust-lang#93393

Replace unwrap with ? in TcpListener doc

943f833

Rollup merge of rust-lang#107354 - tspiteri:source-serif-4.005, r=Gui…

233b319

…llaumeGomez rustdoc: update Source Serif 4 from 4.004 to 4.005 [Version 4.005](https://github.com/adobe-fonts/source-serif/releases/tag/4.005R) was released on 2023-01-20.

Rollup merge of rust-lang#107412 - tshepang:needless-check, r=wesleyw…

c6a104f

…iser avoid needless checks

Rollup merge of rust-lang#107467 - WaffleLapkin:uneq, r=oli-obk

53bb632

Improve enum checks Some light refactoring.

Rollup merge of rust-lang#107491 - notriddle:notriddle/setting-check,…

f0e4a1c

… r=GuillaumeGomez rustdoc: remove unused CSS from `.setting-check` These rules were needed for the mobile-style switches, but those were removed in 0f3ae62

Rollup merge of rust-lang#107508 - WaffleLapkin:uneq'15, r=oli-obk

fe44f3b

`Edition` micro refactor r? ``@oli-obk``

Rollup merge of rust-lang#107525 - RalfJung:pointee-info, r=eddyb

7e6fc82

PointeeInfo is advisory only rust-lang#107248 fixed PointeeInfo being used in ways that don't actually work. Hopefully this comments helps avoid such issues in the future. Cc ``@eddyb``

GuillaumeGomez added 2 commits January 31, 2023 23:38

Rollup merge of rust-lang#107527 - notriddle:notriddle/wcagcontrast, …

9e0bfe0

…r=GuillaumeGomez rustdoc: stop making unstable items transparent Fixes rust-lang#93393

Rollup merge of rust-lang#107535 - dcompoze:tcp-doc-unwrap, r=cuviper

adc3f8a

Replace unwrap with ? in TcpListener doc The example in TcpListener doc returns `std::io::Result<()>` but the code inside the function uses `unwrap()` instead of `?`.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 1, 2023

bors merged commit ad8e1dc into rust-lang:master Feb 1, 2023

rustbot added this to the 1.69.0 milestone Feb 1, 2023

This was referenced Feb 1, 2023

Add more license annotations #104527

Merged

Revert "Teach parser to understand fake anonymous enum syntax" and related commits #107478

Merged

GuillaumeGomez deleted the rollup-xv7dx2h branch February 1, 2023 10:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 12 pull requests #107536

Rollup of 12 pull requests #107536

GuillaumeGomez commented Jan 31, 2023

GuillaumeGomez commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Feb 1, 2023

bors commented Feb 1, 2023

rust-timer commented Feb 1, 2023

rust-timer commented Feb 1, 2023

Rollup of 12 pull requests #107536

Rollup of 12 pull requests #107536

Conversation

GuillaumeGomez commented Jan 31, 2023

GuillaumeGomez commented Jan 31, 2023

bors commented Jan 31, 2023

bors commented Feb 1, 2023

bors commented Feb 1, 2023

rust-timer commented Feb 1, 2023

rust-timer commented Feb 1, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles