Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pretty-printing of HirIdValidator errors #107515

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Improve pretty-printing of HirIdValidator errors #107515

merged 1 commit into from
Feb 2, 2023

Commits on Feb 1, 2023

  1. Improve pretty-printing of HirIdValidator errors 

    This now uses `node_to_string` for both missing and seen Ids, which includes
the snippet of code for which the Id was allocated.
Also removes the duplicated printing of `HirId`, as `node_to_string` includes that already.
Similarly, changes all other users of `node_to_string` that do so, and changes the output of `node_to_string`, which is now "$hirid ($what `$span` in $path)".
    @Swatinem
    Swatinem committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3a75f10 View commit details
    Browse the repository at this point in the history