Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Revert #104889 #107083

Merged
merged 6 commits into from
Jan 20, 2023
Merged

rustdoc: Revert #104889 #107083

merged 6 commits into from
Jan 20, 2023

Conversation

GuillaumeGomez
Copy link
Member

Reverts #104889.

I don't think I'll be able to finish #107000 on time unfortunately so to prevent #106373, better to revert it and to make it into the next release.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 19, 2023
@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 19, 2023

📌 Commit a22cd9c has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2023
@GuillaumeGomez
Copy link
Member Author

Since it impacts perf, it can't be put into a rollup and we need it merged before tomorrow so let's give it a higher priority.

@bors rollup=never p=1

@bors
Copy link
Contributor

bors commented Jan 20, 2023

⌛ Testing commit a22cd9c with merge 51d50ea...

@bors
Copy link
Contributor

bors commented Jan 20, 2023

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 51d50ea to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 20, 2023
@bors bors merged commit 51d50ea into rust-lang:master Jan 20, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 20, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (51d50ea): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-4.4% [-15.7%, -0.5%] 7
Improvements ✅
(secondary)
-1.5% [-1.6%, -1.4%] 3
All ❌✅ (primary) -4.4% [-15.7%, -0.5%] 7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)
-2.1% [-3.3%, -1.2%] 3
Improvements ✅
(secondary)
-1.9% [-2.0%, -1.7%] 2
All ❌✅ (primary) -2.1% [-3.3%, -1.2%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)
-6.5% [-14.7%, -1.5%] 5
Improvements ✅
(secondary)
-2.3% [-2.5%, -2.1%] 2
All ❌✅ (primary) -6.5% [-14.7%, -1.5%] 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants