Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR "Rework some predicates_of/{Generic,Instantiated}Predicates… #106961

Closed

Conversation

compiler-errors
Copy link
Member

Reverts #106395
r? @ghost


Revert "Remove bound_{explicit,}_item_bounds"

This reverts commit 90df86f.

Revert "drive-by: assert when iterating through InstantiatedPredicates"

This reverts commit e1533a2.

Revert "Make InstantiatedPredicates impl IntoIterator"

This reverts commit 9b28edb.

Revert "instantiate_own doesn't need to return a pair of vectors"

This reverts commit 91fd862.

… code"

Revert "Remove bound_{explicit,}_item_bounds"

This reverts commit 90df86f.

Revert "drive-by: assert when iterating through InstantiatedPredicates"

This reverts commit e1533a2.

Revert "Make InstantiatedPredicates impl IntoIterator"

This reverts commit 9b28edb.

Revert "instantiate_own doesn't need to return a pair of vectors"

This reverts commit 91fd862.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 17, 2023
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 17, 2023
@bors
Copy link
Contributor

bors commented Jan 17, 2023

⌛ Trying commit d0c877b with merge ed754dfa2bae04c79d17fa520184153050da7798...

@bors
Copy link
Contributor

bors commented Jan 17, 2023

☀️ Try build successful - checks-actions
Build commit: ed754dfa2bae04c79d17fa520184153050da7798 (ed754dfa2bae04c79d17fa520184153050da7798)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ed754dfa2bae04c79d17fa520184153050da7798): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.6% [3.2%, 6.5%] 3
Improvements ✅
(primary)
-1.6% [-2.1%, -1.2%] 2
Improvements ✅
(secondary)
-4.0% [-5.8%, -2.2%] 2
All ❌✅ (primary) -1.6% [-2.1%, -1.2%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 17, 2023
@compiler-errors compiler-errors deleted the revert-for-perf-1 branch August 11, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants