Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve a TAIT error and add an error code plus documentation #106940

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Improve a TAIT error and add an error code plus documentation #106940

merged 1 commit into from
Jan 16, 2023

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 16, 2023

cc #106858

@compiler-errors
Copy link
Member

r? @compiler-errors

compiler-errors
compiler-errors approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) soon.

r=me with nits applied if u want

compiler/rustc_error_codes/src/error_codes/E0792.md Outdated Show resolved Hide resolved
tests/ui/consts/const_in_pattern/issue-73431.stderr Outdated Show resolved Hide resolved
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 16, 2023

@bors ping

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2023

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 16, 2023

@bors r=compiler-errors

@compiler-errors
Copy link
Member

@bors ping

@bjorn3 bjorn3 closed this Jan 16, 2023
@bjorn3 bjorn3 reopened this Jan 16, 2023
@bjorn3
Copy link
Member

bjorn3 commented Jan 16, 2023

@bors ping

@bors
Copy link
Contributor

bors commented Jan 16, 2023

😪 I'm awake I'm awake

@bjorn3
Copy link
Member

bjorn3 commented Jan 16, 2023

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Jan 16, 2023

📌 Commit 6b69b5e has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 16, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2023
@bors
Auto merge of rust-lang#106945 - matthiaskrgr:rollup-c5or8z3, r=matth…
4781233 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#105954 (Update instrument-coverage.md)
 - rust-lang#106835 (new trait solver: rebase impl substs for gats correctly)
 - rust-lang#106912 (check -Z query-dep-graph is enabled if -Z dump-dep-graph (rust-lang#106736))
 - rust-lang#106940 (Improve a TAIT error and add an error code plus documentation)
 - rust-lang#106942 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d2a8a9f into rust-lang:master Jan 16, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @compiler-errors @BoxyUwU @rustbot @bjorn3 @bors