Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit only one nbsp error per file #106872

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Emit only one nbsp error per file #106872

merged 2 commits into from
Jan 16, 2023

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jan 14, 2023

Fixes #106101.

See #106098 for an explanation of how someone would end up with a large number of these nbsp characters in their source code, which is why I think rustc needs to handle this specific case in a friendlier way.

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 14, 2023
@fee1-dead
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 16, 2023

📌 Commit dab06cc has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2023
@bors
Copy link
Contributor

bors commented Jan 16, 2023

⌛ Testing commit dab06cc with merge a5bfc25...

@fee1-dead fee1-dead self-assigned this Jan 16, 2023
@bors
Copy link
Contributor

bors commented Jan 16, 2023

☀️ Test successful - checks-actions
Approved by: fee1-dead
Pushing a5bfc25 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 16, 2023
@bors bors merged commit a5bfc25 into rust-lang:master Jan 16, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 16, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a5bfc25): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.7% [-0.8%, -0.7%] 4
Improvements ✅
(secondary)
-0.6% [-1.1%, -0.3%] 15
All ❌✅ (primary) -0.7% [-0.8%, -0.7%] 4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.1% [2.9%, 3.3%] 2
Regressions ❌
(secondary)
2.1% [1.5%, 2.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.1% [2.9%, 3.3%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

@dtolnay dtolnay deleted the nbsp branch January 16, 2023 19:33
@dtolnay dtolnay removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many errors on non-breaking space characters in source code
6 participants