Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove redundant CSS .code-wrapper { position: relative } #106279

Closed

Conversation

notriddle
Copy link
Contributor

This line, added in 4b3f82a, was part of how the expand/prev/next buttons were aligned.

Now that 6ccd14a made the outer wrapper has relative position, though, it doesn't matter any more, because those buttons will get the same position when they're made relative to that.

This line, added in 4b3f82a, was part of
how the expand/prev/next buttons were aligned.

Now that 6ccd14a made the outer wrapper
has relative position, though, it doesn't matter any more, because those
buttons will get the same position when they're made relative to that.
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2022

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 30, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@notriddle
Copy link
Contributor Author

Wait, no. This doesn't work. It isn't the same on small screens 🤦.

image

@notriddle notriddle closed this Dec 30, 2022
@notriddle notriddle deleted the notriddle/code-wrapper-position branch December 30, 2022 00:34
jyn514 added a commit to jyn514/rust that referenced this pull request Dec 30, 2022
…ples-layout-test, r=notriddle

Extend scraped examples layout GUI test for position of buttons

This is a regression test for rust-lang#106279.

r? `@notriddle`
jyn514 added a commit to jyn514/rust that referenced this pull request Dec 31, 2022
…ples-layout-test, r=notriddle

Extend scraped examples layout GUI test for position of buttons

This is a regression test for rust-lang#106279.

r? ``@notriddle``
jyn514 added a commit to jyn514/rust that referenced this pull request Dec 31, 2022
…ples-layout-test, r=notriddle

Extend scraped examples layout GUI test for position of buttons

This is a regression test for rust-lang#106279.

r? ```@notriddle```
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Dec 31, 2022
…ples-layout-test, r=notriddle

Extend scraped examples layout GUI test for position of buttons

This is a regression test for rust-lang#106279.

r? ````@notriddle````
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants