Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #105703

Merged
merged 15 commits into from
Dec 14, 2022
Merged

Rollup of 7 pull requests #105703

merged 15 commits into from
Dec 14, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Michael Benfield and others added 15 commits December 7, 2022 19:58
On Linux, use mmap64, open64, openat64, and sendfile64 in place of their
non-LFS counterparts.

This is relevant to rust-lang#94173.

With these changes (together with rust-lang/backtrace-rs#501), the
simple binaries I produce with rustc seem to have no non-LFS functions,
so maybe rust-lang#94173 is fixed. But I can't be sure if I've missed something
and maybe some non-LFS functions could sneak in somehow.
.. for now. I have been burned out a bit from reviews
and I think I should take a break.
Use more LFS functions.

On Linux, use mmap64, open64, openat64, and sendfile64 in place of their non-LFS counterparts.

This is relevant to rust-lang#94173.

With these changes (together with rust-lang/backtrace-rs#501), the simple binaries I produce with rustc seem to have no non-LFS functions, so maybe rust-lang#94173 is fixed. But I can't be sure if I've missed something and maybe some non-LFS functions could sneak in somehow.
…orn3

Fix transmutes between pointers in different address spaces (e.g. fn ptrs on AVR)

Currently, this causes a verifier error (https://godbolt.org/z/YYohed4bj), since it uses `bitcast`, which can't convert between address spaces.

Uncovered due to rust-lang#105545 (comment)

r? `@bjorn3`
explain mem::forget(env_lock) in fork/exec

I stumbled upon this while doing triage for rust-lang#64718.
…yn514

Fix unsoundness in bootstrap cache code

Discovered via rust-lang#105575, which showed that rustc was failing to build during a perf run.
Add a test for rust-lang#92481

The test was copied ad-hoc from rust-lang#92481, but I can't get the test to pass, because of needing to get twice the same error on the last line of the source.

Closes rust-lang#92481
…-name, r=notriddle

Improve rustdoc markdown variable naming

Opened on the right repository this time. 😆

r? `@notriddle`
…Mark-Simulacrum

Remove fee1-dead from reviewers

.. for now. I have been burned out a bit from reviews and I think I should take a break.
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 14, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented Dec 14, 2022

📌 Commit 3069bc0 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2022
@bors
Copy link
Contributor

bors commented Dec 14, 2022

⌛ Testing commit 3069bc0 with merge b70baa4...

@bors
Copy link
Contributor

bors commented Dec 14, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing b70baa4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 14, 2022
@bors bors merged commit b70baa4 into rust-lang:master Dec 14, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 14, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#105697 7590b3c6ed181e13dadda52b35a29791e1c4782f
#105684 c29fda996e02c13cf2f2b8f49ccb9a3172ab6e91
#105630 6d550a72349504bc002dccf8a4d39fa8dea09034
#105624 63b87b1821f66d475cda70e9fcd39665301ceb0c
#105598 7a06b9a3d97952765475361934887af7363b1ae2
#105578 1eb02226ef048fa76137c26ee34ffa24c7f9fba3
#105399 a3686041ca198ec49637cd7a2541c435402df0bb

previous master: fbf8b937b4

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b70baa4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.0% [-2.0%, -2.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@matthiaskrgr matthiaskrgr deleted the rollup-tfpeam2 branch December 22, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants