Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_parse: diagnostics migration, v4 #105670

Merged
merged 11 commits into from
Feb 2, 2023
Merged

rustc_parse: diagnostics migration, v4 #105670

merged 11 commits into from
Feb 2, 2023

Commits on Feb 1, 2023

  1. Forbid #[suggestion_*(...)] on Vecs 

    It is ambiguous whether this should produce several `.span_suggestions()`
calls or one `.multipart_suggestions()` call.
    @Xiretza
    Xiretza committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    f2acbb9 View commit details
    Browse the repository at this point in the history

  2. rustc_parse: avoid creating unnecessary intermediate strings

    @Xiretza
    Xiretza committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    0e36e7c View commit details
    Browse the repository at this point in the history

  3. Use AddToDiagnostic for "use latest edition" help

    @Xiretza
    Xiretza committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    fc0ba2c View commit details
    Browse the repository at this point in the history

  4. Implement IntoDiagnosticArg for ast::Visibility

    @Xiretza
    Xiretza committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    a84adba View commit details
    Browse the repository at this point in the history

  5. Fix condition for "missing struct" diagnostic on tuple structs 

    The check previously matched this, and suggested adding a missing
`struct`:

pub Foo(...):

It was probably intended to match this instead (semicolon instead of
colon):

pub Foo(...);
    @Xiretza
    Xiretza committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    0757d5f View commit details
    Browse the repository at this point in the history

  6. tests: rename test cases to match new behaviour

    @Xiretza
    Xiretza committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    ac9c66b View commit details
    Browse the repository at this point in the history

  7. rustc_parse: migrate more to diagnostic structs

    @Xiretza
    Xiretza committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    87ef37d View commit details
    Browse the repository at this point in the history

  8. Convert rustc_parse::parser::pat::Expected to enum 

    This is required in order to support translatable diagnostics.
    @Xiretza
    Xiretza committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9564a30 View commit details
    Browse the repository at this point in the history

  9. migrate parser::ty to diagnostic structs

    @Xiretza
    Xiretza committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7631b12 View commit details
    Browse the repository at this point in the history

  10. rustc_parse: revert conversion of "non-item in item list" diagnostic 

    #[derive(Subdiagnostic)] does not allow multiple subdiagnostics on one
variant, as in NonItemInItemListSub::Other.
    @Xiretza
    Xiretza committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    a476683 View commit details
    Browse the repository at this point in the history

  11. Make "use latest edition" subdiagnostic translatable

    @Xiretza
    Xiretza committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    0d0d369 View commit details
    Browse the repository at this point in the history