Issue 5121 fns with early lifetime params #10556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f whether they appear in a trait bound. Fixes rust-lang#5121.
| ItemScope(&'self OptVec<ast::Lifetime>), | ||
| FnScope(ast::NodeId, &'self OptVec<ast::Lifetime>, &'self ScopeChain<'self>), | ||
| BlockScope(ast::NodeId, &'self ScopeChain<'self>), | ||
| EarlyScope(uint, &'self OptVec<ast::Lifetime>, Scope<'self>), |
There was a problem hiding this comment.
Please document the first tuple component of EarlyScope. (Or, alternatively, provide a pointer, such as a function name, to which part of the code you'd recommend reading to find out what they are.)
|
I skimmed over it, gave feedback. Feel free to update. I will look at it again tomorrow. |
|
Actually I was a bit hasty with this PR. It's close, but there's still work to be done, so I'm going to close it for now. I'll read over and incorporate your feedback also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #5121 for details.
r? @pnkfelix