Print all features with --print target-features #104627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
|
Thanks! |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 29, 2022
…s, r=compiler-errors Print all features with --print target-features This fixes `rustc --print target-features` with respect to aliases and tied features. Before this change, the print command assumed that each LLVM feature corresponds exactly to one rustc feature. In the case of aliases and tied features, this assumption failed and some features (such as aarch64's "pacg") were missing. With this change, every target feature is listed.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 30, 2022
…iaskrgr Rollup of 14 pull requests Successful merges: - rust-lang#103876 (type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds) - rust-lang#104427 (Explain why `rematch_impl` fails to be infallible) - rust-lang#104436 (Add slice to the stack allocated string comment) - rust-lang#104523 (Don't use periods in target names) - rust-lang#104627 (Print all features with --print target-features) - rust-lang#104911 (Make inferred_outlives_crate return Clause) - rust-lang#105002 (Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str`) - rust-lang#105023 (Statics used in reachable function's inline asm are reachable) - rust-lang#105045 (`rustc_ast_{passes,pretty}`: remove `ref` patterns) - rust-lang#105049 (Hermit: Minor build fixes) - rust-lang#105051 (Replace a macro with a function) - rust-lang#105062 (rustdoc: use shorthand background for rustdoc toggle CSS) - rust-lang#105066 (move `candidate_from_obligation` out of assembly) - rust-lang#105068 (Run patchelf also on rust-analyzer-proc-macro-srv.) Failed merges: - rust-lang#105050 (Remove useless borrows and derefs) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
rustc --print target-featureswith respect to aliases and tied features.Before this change, the print command assumed that each LLVM feature corresponds exactly to one rustc feature. In the case of aliases and tied features, this assumption failed and some features (such as aarch64's "pacg") were missing. With this change, every target feature is listed.