Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #104270

Closed
wants to merge 33 commits into from
Closed

Commits on Sep 24, 2022

  1. Implement the +whole-archive modifier for wasm-ld

    This implements the `Linker::{link_whole_staticlib,link_whole_rlib}`
    methods for the `WasmLd` linker used on wasm targets. Previously these
    methods were noops since I think historically `wasm-ld` did not have
    support for `--whole-archive` but nowadays it does, so the flags are
    passed through.
    alexcrichton committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    6630c14 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Improve diagnostic when passing arg to closure and missing borrow.

    This checks the number of references for the given and expected type and
    shows hints to the user if the numbers don't match.
    Akida31 committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    fb9d98c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4992e8c View commit details
    Browse the repository at this point in the history
  3. Remove hint from help message

    Akida31 committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    e8cd512 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    23c99a4 View commit details
    Browse the repository at this point in the history
  5. change error message

    Akida31 committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    121b431 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0f5409b View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2022

  1. Configuration menu
    Copy the full SHA
    449a440 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Configuration menu
    Copy the full SHA
    c0447b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a46af18 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Configuration menu
    Copy the full SHA
    32a2f0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2716449 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Fix broken link in error code E0706 docs

    Corresponding subsection in async book is not `07.05` not `07.06`.
    
    The information on the linked page is the same so it may be reasonable to remove the whole sentence.
    PeteDevoy authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    4b5cff5 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Configuration menu
    Copy the full SHA
    8e0cac1 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Configuration menu
    Copy the full SHA
    303653e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a45151e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0e0bcd9 View commit details
    Browse the repository at this point in the history
  4. Add retry flag to remote-test-server

    This allows retrying binding TCP Socket multiple times. This is useful
    when using emulators as network might not be available in the beginning.
    This was orignally implemented in rust-lang#100316
    
    Signed-off-by: Ayush Singh <[email protected]>
    Ayush1325 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    06a77af View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Configuration menu
    Copy the full SHA
    53e8b49 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Tweak span for #[must_use]

    Do not point at whole statement, only at the expression (skip pointing at `;`)
    estebank committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    50bb7a4 View commit details
    Browse the repository at this point in the history
  2. Consider #[must_use] annotation on async fn as also affecting the…

    … `Future::Output`
    
    No longer lint against `#[must_use] async fn foo()`.
    
    When encountering a statement that awaits on a `Future`, check if the
    `Future`'s parent item is annotated with `#[must_use]` and emit a lint
    if so. This effectively makes `must_use` an annotation on the
    `Future::Output` instead of only the `Future` itself.
    
    Fix rust-lang#78149.
    estebank committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    243496e View commit details
    Browse the repository at this point in the history
  3. review comments

    estebank committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    8bd8484 View commit details
    Browse the repository at this point in the history
  4. Fix tests after rebase

    estebank committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    f57713b View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#100633 - estebank:must_use_async_fn_return,…

    … r=tmandry
    
    Consider `#[must_use]` annotation on `async fn` as also affecting the `Future::Output`
    
    No longer lint against `#[must_use] async fn foo()`.
    
    When encountering a statement that awaits on a `Future`, check if the
    `Future`'s parent item is annotated with `#[must_use]` and emit a lint
    if so. This effectively makes `must_use` an annotation on the
    `Future::Output` instead of only the `Future` itself.
    
    Fix rust-lang#78149.
    Manishearth authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    37c5efa View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#102215 - alexcrichton:wasm-link-whole-archi…

    …ve, r=estebank
    
    Implement the `+whole-archive` modifier for `wasm-ld`
    
    This implements the `Linker::{link_whole_staticlib,link_whole_rlib}` methods for the `WasmLd` linker used on wasm targets. Previously these methods were noops since I think historically `wasm-ld` did not have support for `--whole-archive` but nowadays it does, so the flags are passed through.
    Manishearth authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    c6251c9 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#102813 - Akida31:issue-64915/simpler_diagno…

    …stic_when_passing_arg_to_closure_and_missing_borrow, r=estebank
    
    Simpler diagnostic when passing arg to closure and missing borrow
    
    fixes rust-lang#64915
    
    I followed roughly the instructions and the older PR rust-lang#76362.
    The number of references for the expected and the found types will be compared and depending on which has more the diagnostic will be emitted.
    
    I'm not quite sure if my approach with the many `span_bug!`s is good, it could lead to some ICEs. Would it be better if  those errors are ignored?
    
    As far as I know the following code works similarly but in a different context. Is this probably reusable since it looks like it would emit better diagnostics?
    https://github.com/rust-lang/rust/blob/a688a0305fad9219505a8f2576446510601bafe8/compiler/rustc_hir_analysis/src/check/demand.rs#L713-L1061
    
    When running the tests locally, a codegen test failed. Is there something I can/ should do about that?
    
    If you have some improvements/ corrections please say so and I will happily include them.
    
    r? `@estebank` (as you added the mentoring instructions to the issue)
    Manishearth authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    82cb9ee View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#103445 - fmease:fix-50291, r=estebank

    `#[test]`: Point at return type if `Termination` bound is unsatisfied
    
    Together with rust-lang#103142 (already merged) this fully fixes rust-lang#50291.
    
    I don't consider my current solution of changing a few spans “here and there” very clean since the
    failed obligation is a `FunctionArgumentObligation` and we point at a type instead of a function argument.
    
    If you agree with me on this point, I can offer to keep the spans of the existing nodes and instead inject
    `let _: AssertRetTyIsTermination<$ret_ty>;` (type to be defined in `libtest`) similar to `AssertParamIsEq` etc.
    used by some built-in derive-macros.
    
    I haven't tried that approach yet though and cannot promise that it would actually work out or
    be “cleaner” for that matter.
    
    `@rustbot` label A-libtest A-diagnostics
    r? `@estebank`
    Manishearth authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    8048504 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#103468 - chenyukang:yukang/fix-103435-extra…

    …-parentheses, r=estebank
    
    Fix unused lint and parser caring about spaces to won't produce invalid code
    
    Fixes rust-lang#103435
    Manishearth authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    6c35e1a View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#103531 - chenyukang:yukang/fix-103474, r=es…

    …tebank
    
    Suggest calling the instance method of the same name when method not found
    
    Fixes rust-lang#103474
    Manishearth authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    be70abe View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#103924 - PeteDevoy:patch-1, r=estebank

    Fix broken link in description of error code E0706
    
    Corresponding subsection in async book is `07.05` not `07.06`.
    
    The information on the linked page is the same so it may be reasonable to remove the whole sentence.
    Manishearth authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    7658f0e View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#104110 - krasimirgg:msan-16, r=nagisa

    prevent uninitialized access in black_box for zero-sized-types
    
    Don't read the pointer location in black_box for zero sized types, just emit a memory clobber instead. Addresses  rust-lang#103304 when rust is build against LLVM at HEAD.
    
    Zulip thread: https://rust-lang.zulipchat.com/#narrow/stream/187780-t-compiler.2Fwg-llvm/topic/.28with.20llvm.20at.20HEAD.29.3A.20msan.20error.20in.20core.3A.3Ahint.3A.3Ablack_box
    Manishearth authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    55f07c7 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    206928c View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#104146 - Ayush1325:remote-test-server, r=jy…

    …n514
    
    Retry binding TCP Socket in remote-test-server
    
    This allows retrying binding TCP Socket multiple times. This is useful when using emulators as network might not be available in the beginning.
    
    This was orignally implemented in rust-lang#100316
    
    Signed-off-by: Ayush Singh <[email protected]>
    Manishearth authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    fe41af6 View commit details
    Browse the repository at this point in the history