-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest removing unnecessary .
to use a floating point literal
#104144
Merged
bors
merged 3 commits into
rust-lang:master
from
TaKO8Ki:suggest-removing-unnecessary-dot
Nov 12, 2022
Merged
Suggest removing unnecessary .
to use a floating point literal
#104144
bors
merged 3 commits into
rust-lang:master
from
TaKO8Ki:suggest-removing-unnecessary-dot
Nov 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @fee1-dead (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 8, 2022
fee1-dead
reviewed
Nov 8, 2022
src/test/ui/suggestions/unnecessary_dot_for_floating_point_literal.stderr
Outdated
Show resolved
Hide resolved
Rageking8
reviewed
Nov 8, 2022
estebank
reviewed
Nov 8, 2022
TaKO8Ki
force-pushed
the
suggest-removing-unnecessary-dot
branch
from
November 9, 2022 22:25
f85bbde
to
7ffe5f5
Compare
@bors r+ |
📌 Commit 7ffe5f59ab323fa3e731f64434bac5a4720a50ec has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 9, 2022
☔ The latest upstream changes (presumably #104246) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 10, 2022
TaKO8Ki
force-pushed
the
suggest-removing-unnecessary-dot
branch
from
November 11, 2022 01:53
7ffe5f5
to
6018f11
Compare
@bors r=fee1-dead |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 11, 2022
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 11, 2022
…ry-dot, r=fee1-dead Suggest removing unnecessary `.` to use a floating point literal Fixes a part of rust-lang#101883
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 11, 2022
…ry-dot, r=fee1-dead Suggest removing unnecessary `.` to use a floating point literal Fixes a part of rust-lang#101883
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 11, 2022
…ry-dot, r=fee1-dead Suggest removing unnecessary `.` to use a floating point literal Fixes a part of rust-lang#101883
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 12, 2022
…ry-dot, r=fee1-dead Suggest removing unnecessary `.` to use a floating point literal Fixes a part of rust-lang#101883
This was referenced Nov 12, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 12, 2022
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#104110 (prevent uninitialized access in black_box for zero-sized-types) - rust-lang#104117 (Mark `trait_upcasting` feature no longer incomplete.) - rust-lang#104144 (Suggest removing unnecessary `.` to use a floating point literal) - rust-lang#104250 (Migrate no result page link color to CSS variables) - rust-lang#104261 (More accurately report error when formal and expected signature types differ) - rust-lang#104263 (Add a reference to ilog2 in leading_zeros integer docs) - rust-lang#104308 (Remove the old `ValidAlign` name) - rust-lang#104319 (Fix non clickable source link) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a part of #101883