-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #103829
Rollup of 10 pull requests #103829
Conversation
Huge spans aren't good for IDE users as they underline constructs that are possibly multiline.
`x.ps1` and `x` will now search for python executables like `python3.9` and `python3.10.exe`
…very, r=jyn514 Add better python discovery The Microsoft Store version of Python installs itself as `pythonM.m`, with `M` being the major version and `m` the minor. The `x.ps1` script will now search for python executables whose command matches the regex `python\d`. The `\d` at the end is to protect from using the `pythonw` versions, which do not work as standard python.
…, r=davidtwco Update note about unstable split-debuginfo flag. split-debuginfo was effectively stabilized in rust-lang#98051. The note about it requiring `-Z unstable-options` is no longer accurate. The rules for when it is gated and when it is supported are somewhat complex. I considered removing the note entirely, or making it more generic, but opted to instead try to summarize the current state.
…dead Add `walk_generic_arg` Could this please be added? I could use it for a Clippy lint.
…span, r=cjgillot Reduce span of let else irrefutable_let_patterns warning Huge spans aren't good for IDE users as they underline constructs that are possibly multiline. Similar PR to rust-lang#90761 which did the same for the `unused_macros` lint.
…rence-err, r=davidtwco better error for `rustc_strict_coherence` misuse Fixes rust-lang#103753
…r=compiler-errors Fix ICE in checking transmutability of NaughtyLenArray Fixes rust-lang#103783
…-in-impl-items, r=GuillaumeGomez rustdoc: add margins to all impl-item toggles, not just methods Fixes rust-lang#103782 ## Before ![image](https://user-images.githubusercontent.com/1593513/198943087-8cab8b25-2092-49d6-89b4-caa2989dedf0.png) ## After ![image](https://user-images.githubusercontent.com/1593513/198943111-bc08c2d6-f058-4362-b999-0caf09eb93bf.png)
interpret: move type_name implementation to an interpreter-independent helper file This should avoid pinging rust-lang/miri each time that file changes, which is really not necessary. r? `@oli-obk`
…struct-field, r=notriddle Remove generation of tuple struct fields in the search index This comes from [this discussion](rust-lang#103710) as they're not very useful. r? `@notriddle`
…n514 Enable RUSTC_BOOTSTRAP for a few steps This forward-ports this commit so we don't need to keep applying it when branching beta (as done in 1.64, 1.65, and 1.66 beta bumps).
@bors r+ p=10 rollup=never |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: 024207ab43 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (dc05f60): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
The regressions are just noise. The improvements to @rustbot label: +perf-regression-triaged |
Successful merges:
walk_generic_arg
#103692 (Addwalk_generic_arg
)rustc_strict_coherence
misuse #103772 (better error forrustc_strict_coherence
misuse)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup