Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary &str to String conversions #103726

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Avoid unnecessary &str to String conversions #103726

merged 1 commit into from
Oct 30, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Oct 29, 2022

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2022

r? @spastorino

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 29, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2022

Some changes occurred in const_evaluatable.rs

cc @lcnr

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 29, 2022

📌 Commit a3a3f4d has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 30, 2022
@bors
Auto merge of rust-lang#103745 - matthiaskrgr:rollup-hipjva8, r=matth…
4827cee 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#100006 (Make `core::mem::copy` const)
 - rust-lang#102659 (1.65.0 release notes)
 - rust-lang#103124 (Add tests for autoderef on block tail)
 - rust-lang#103253 (rustdoc: add test case for masked blanket impl)
 - rust-lang#103715 (use consistent terminology)
 - rust-lang#103722 (Fix z-indexes of code example feature and cleanup its CSS)
 - rust-lang#103726 (Avoid unnecessary `&str` to `String` conversions)
 - rust-lang#103737 (rustdoc: use CSS margin/padding shorthand when all are being set)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2bff9e2 into rust-lang:master Oct 30, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 30, 2022
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.66.0, 1.67.0 Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
6 participants
@TaKO8Ki @rustbot @compiler-errors @bors @spastorino @Mark-Simulacrum