Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin::new_unchecked: discuss pinning closure captures #103396

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Pin::new_unchecked: discuss pinning closure captures #103396

merged 1 commit into from
Nov 22, 2022

Conversation

RalfJung
Copy link
Member

Regardless of how the discussion in #102737 turns out, pinning closure captures is super subtle business and probably worth discussing separately.

@rustbot
Copy link
Collaborator

rustbot commented Oct 22, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 22, 2022
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2022
@RalfJung RalfJung mentioned this pull request Oct 22, 2022
Merged
@RalfJung RalfJung force-pushed the pinning-closure-captures branch 2 times, most recently from a35b335 to dcd61f0 Compare October 22, 2022 09:24
yotamofek
yotamofek reviewed Oct 22, 2022
View reviewed changes
library/core/src/pin.rs Outdated Show resolved Hide resolved
@RalfJung RalfJung force-pushed the pinning-closure-captures branch from dcd61f0 to 964290a Compare October 22, 2022 16:11
@RalfJung
Copy link
Member Author

Cc @rust-lang/wg-async
maybe one of you can take the review :)

eholk
eholk approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@eholk eholk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think it's a really clear explanation of the issues here.

I'm not on the libs team, so I'll let a libs team member do the final signoff.

@RalfJung
Copy link
Member Author

r? libs-api

@rustbot rustbot assigned dtolnay and unassigned joshtriplett Oct 29, 2022
@RalfJung
Copy link
Member Author

@rust-lang/libs-api what is needed to make progress here? This has been waiting for review for quite a while.

@dtolnay
Copy link
Member

dtolnay commented Nov 21, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 21, 2022

📌 Commit 964290a has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 21, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2022
@bors
Auto merge of rust-lang#104696 - matthiaskrgr:rollup-gi1pdb0, r=matth…
0f7d817 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#103396 (Pin::new_unchecked: discuss pinning closure captures)
 - rust-lang#104416 (Fix using `include_bytes` in pattern position)
 - rust-lang#104557 (Add a test case for async dyn* traits)
 - rust-lang#104559 (Split `MacArgs` in two.)
 - rust-lang#104597 (Probe + better error messsage for `need_migrate_deref_output_trait_object`)
 - rust-lang#104656 (Move tests)
 - rust-lang#104657 (Do not check transmute if has non region infer)
 - rust-lang#104663 (rustdoc: factor out common button CSS)
 - rust-lang#104666 (Migrate alias search result to CSS variables)
 - rust-lang#104674 (Make negative_impl and negative_impl_exists take the right types)
 - rust-lang#104692 (Update test's cfg-if dependency to 1.0)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3278dea into rust-lang:master Nov 22, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 22, 2022
@RalfJung RalfJung deleted the pinning-closure-captures branch November 22, 2022 10:19
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 1, 2022
@bors
Auto merge of rust-lang#104696 - matthiaskrgr:rollup-gi1pdb0, r=matth…
e6c33e0 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#103396 (Pin::new_unchecked: discuss pinning closure captures)
 - rust-lang#104416 (Fix using `include_bytes` in pattern position)
 - rust-lang#104557 (Add a test case for async dyn* traits)
 - rust-lang#104559 (Split `MacArgs` in two.)
 - rust-lang#104597 (Probe + better error messsage for `need_migrate_deref_output_trait_object`)
 - rust-lang#104656 (Move tests)
 - rust-lang#104657 (Do not check transmute if has non region infer)
 - rust-lang#104663 (rustdoc: factor out common button CSS)
 - rust-lang#104666 (Migrate alias search result to CSS variables)
 - rust-lang#104674 (Make negative_impl and negative_impl_exists take the right types)
 - rust-lang#104692 (Update test's cfg-if dependency to 1.0)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yotamofek yotamofek yotamofek left review comments

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

@dtolnay dtolnay dtolnay approved these changes

@eholk eholk eholk approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
9 participants
@RalfJung @rustbot @rust-highfive @dtolnay @bors @eholk @yotamofek @yoshuawuyts @joshtriplett