-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape string literals when fixing overlong char literal #103354
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
Also fixing the case of |
Hm, this doesn't handle the case where we have already have an escaped literal like |
Also, can you remove the intermediate commits like 51f2826f7fc866c29842cc541684dd6ce066ba88 where you tried something and it didn't end up working out? It's not useful to keep those in the commit history, imo. |
57c443e
to
8762485
Compare
Thanks @bors r+ rollup |
…r=compiler-errors Escape string literals when fixing overlong char literal Fixes rust-lang#103323 `@rustbot` label +A-diagnostics +A-suggestion-diagnostics
…r=compiler-errors Escape string literals when fixing overlong char literal Fixes rust-lang#103323 ``@rustbot`` label +A-diagnostics +A-suggestion-diagnostics
…r=compiler-errors Escape string literals when fixing overlong char literal Fixes rust-lang#103323 ```@rustbot``` label +A-diagnostics +A-suggestion-diagnostics
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103123 (Introduce `subst_iter` and `subst_iter_copied` on `EarlyBinder` ) - rust-lang#103328 (Do not suggest trivially false const predicates) - rust-lang#103354 (Escape string literals when fixing overlong char literal) - rust-lang#103355 (Handle return-position `impl Trait` in traits properly in `register_hidden_type`) - rust-lang#103368 (Delay ambiguity span bug in normalize query iff not rustdoc) - rust-lang#103388 (rustdoc: remove unused CSS class `.result-description`) - rust-lang#103399 (Change `unknown_lint` applicability to `MaybeIncorrect`) - rust-lang#103401 (Use functions for headings rustdoc GUI test) - rust-lang#103412 (Fix typo in docs of `String::leak`.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #103323
@rustbot label +A-diagnostics +A-suggestion-diagnostics